From: Michael Ellerman <michael@ellerman.id.au>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: Michael Neuling <mikey@neuling.org>,
Frans Pop <elendil@planet.nl>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
Linas Vepstas <linasvepstas@gmail.com>,
linuxppc-dev@lists.ozlabs.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [RFC PATCH] ppc: don't override CONFIG_PPC_PSERIES_DEBUG
Date: Fri, 15 Oct 2010 11:14:23 +1100 [thread overview]
Message-ID: <1287101663.4194.5.camel@concordia> (raw)
In-Reply-To: <1287078495-11722-1-git-send-email-nacc@us.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
On Thu, 2010-10-14 at 10:48 -0700, Nishanth Aravamudan wrote:
> These files undef DEBUG, but I think they were added before the ability
> to control this from Kconfig.
Perhaps. Some people, *cough*, have a tendency to merge those back in
again from time to time :)
> It's really annoying to only get some of the debug messages!
True, but ..
> Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
>
> ---
> Because the lpar and pci_dlpar code is pretty low-level & verbose,
> perhaps it makes sense to add another Kconfig variable for really
> low-level stuff? But it's annoying to have DEBUG *somewhat* effective,
> especially in the EEH area when doing PCI stuff.
I really don't think you want to enable the lpar debug by default. Have
you tried it? It can make for a pretty unusable system, just because of
the console spam.
Also these days there is CONFIG_DYNAMIC_DEBUG which is much smarter than
all this, but requires setup at runtime.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2010-10-15 0:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-14 17:48 [RFC PATCH] ppc: don't override CONFIG_PPC_PSERIES_DEBUG Nishanth Aravamudan
2010-10-15 0:14 ` Michael Ellerman [this message]
2010-10-15 0:23 ` Nishanth Aravamudan
2010-10-15 0:29 ` Michael Ellerman
2010-10-15 1:47 ` Linas Vepstas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1287101663.4194.5.camel@concordia \
--to=michael@ellerman.id.au \
--cc=anton@samba.org \
--cc=elendil@planet.nl \
--cc=linasvepstas@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=nacc@us.ibm.com \
--cc=paulus@samba.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).