From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: [PATCH v2] pseries: don't override CONFIG_PPC_PSERIES_DEBUG From: Michael Ellerman To: linasvepstas@gmail.com In-Reply-To: References: <1287103733-7121-1-git-send-email-nacc@us.ibm.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-vYaJGuEvRic0IbmPneyK" Date: Fri, 15 Oct 2010 15:01:44 +1100 Message-ID: <1287115304.5278.3.camel@concordia> Mime-Version: 1.0 Cc: Frans Pop , linux-kernel@vger.kernel.org, Paul Mackerras , Anton Blanchard , Brian King , Nishanth Aravamudan , Thomas Gleixner , linuxppc-dev@lists.ozlabs.org Reply-To: michael@ellerman.id.au List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --=-vYaJGuEvRic0IbmPneyK Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, 2010-10-14 at 20:54 -0500, Linas Vepstas wrote: > On 14 October 2010 19:48, Nishanth Aravamudan wrote: > > eeh and pci_dlpar #undef DEBUG, but I think they were added before the > > ability to control this from Kconfig. It's really annoying to only get > > some of the debug messages from these files. Leave the lpar.c #undef > > alone as it produces so much output as to make the kernel unusable. > > Update the Kconfig text to indicate this particular quirk :) > > > > Signed-off-by: Nishanth Aravamudan >=20 > OK, ignore my last email. >=20 > Acked by: Linas Vepstas I guess I'll ack it too seeing I added PPC_PSERIES_DEBUG: Acked-by: Michael Ellerman > > --- a/arch/powerpc/platforms/pseries/Kconfig > > +++ b/arch/powerpc/platforms/pseries/Kconfig > > @@ -47,6 +47,12 @@ config LPARCFG > > config PPC_PSERIES_DEBUG > > depends on PPC_PSERIES && PPC_EARLY_DEBUG > > bool "Enable extra debug logging in platforms/pseries" > > + help > > + Say Y here if you want the pseries core to produce a bunch of > > + debug messages to the system log. Select this if you are havi= ng a > > + problem with the pseries core and want to see more of what is > > + going on. This does not enable debugging in lpar.c, which mus= t > > + be manually done due to its verbosity. > > default y >=20 > Umm, I see "default y" and you are not changing this but ... default y > ?? Really? Yes, default y if early debug is enabled. Unlike DEBUG_KERNEL, PPC_EARLY_DEBUG is a pretty good indication that you are doing some kernel development - because you have to choose exactly which platform you're working on. > Also, I am guessing that the lpar spam is due only to a handful of printk= 's, > while most of the rest will be infrequent. Just knock out the > high-frequency ones... No they're all related to the HPTE code, so you basically don't want any of them enabled unless you're debugging that, and most people aren't. cheers --=-vYaJGuEvRic0IbmPneyK Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (GNU/Linux) iEYEABECAAYFAky30iUACgkQdSjSd0sB4dL+DgCfR+HAWiu5JX9bj+MmeI6209Wc OT4AoMnuNyDQkgC+tfHskbr0cbwBiHyn =fKtT -----END PGP SIGNATURE----- --=-vYaJGuEvRic0IbmPneyK--