From: Michael Ellerman <michael@ellerman.id.au>
To: Joe Perches <joe@perches.com>
Cc: Paul Mackerras <paulus@samba.org>,
Jiri Kosina <trivial@kernel.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/39] arch/powerpc: Update WARN uses
Date: Tue, 02 Nov 2010 14:20:21 +1100 [thread overview]
Message-ID: <1288668021.16790.30.camel@concordia> (raw)
In-Reply-To: <1288662607.366.249.camel@Joe-Laptop>
[-- Attachment #1: Type: text/plain, Size: 716 bytes --]
On Mon, 2010-11-01 at 18:50 -0700, Joe Perches wrote:
> On Tue, 2010-11-02 at 11:26 +1100, Michael Ellerman wrote:
> > On Mon, 2010-11-01 at 07:41 -0700, Joe Perches wrote:
> > > Pretty much. Format coalescing is generally preferred for grep.
> > Really? Grep doesn't work anyway because you have format specifiers, and
> > although you can try and guess them .. good luck, 0x%lx, or 0x%llx, or
> > %#lx or ..
>
> grep "Breakpoint at .* will be disabled"
Sure. For more mundane and repeated error strings the .* can be a pain
in that it matches too much.
But whatever, I'll start writing my code with uncollapsed string
formats, and wait for the torrent of make-it-80-columns patches :)
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2010-11-02 3:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-30 21:08 [PATCH 00/39] Cleanup WARN #defines Joe Perches
2010-10-30 21:08 ` [PATCH 04/39] arch/powerpc: Update WARN uses Joe Perches
2010-11-01 11:02 ` Michael Ellerman
2010-11-01 14:41 ` Joe Perches
2010-11-02 0:26 ` Michael Ellerman
2010-11-02 1:50 ` Joe Perches
2010-11-02 3:20 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288668021.16790.30.camel@concordia \
--to=michael@ellerman.id.au \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).