linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 2/3 RESEND] powerpc: remove cast from void*
       [not found] <cover.1285638395.git.mfm@muteddisk.com>
@ 2010-09-28  2:04 ` matt mooney
  2010-11-03 14:15   ` Jiri Kosina
  0 siblings, 1 reply; 3+ messages in thread
From: matt mooney @ 2010-09-28  2:04 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: kernel-janitors, Paul Mackerras, linuxppc-dev

Unnecessary cast from void* in assignment.

Signed-off-by: matt mooney <mfm@muteddisk.com>
---
 arch/powerpc/platforms/pseries/hvCall_inst.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
index e19ff02..f106662 100644
--- a/arch/powerpc/platforms/pseries/hvCall_inst.c
+++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
@@ -55,7 +55,7 @@ static void hc_stop(struct seq_file *m, void *p)
 static int hc_show(struct seq_file *m, void *p)
 {
 	unsigned long h_num = (unsigned long)p;
-	struct hcall_stats *hs = (struct hcall_stats *)m->private;
+	struct hcall_stats *hs = m->private;
 
 	if (hs[h_num].num_calls) {
 		if (cpu_has_feature(CPU_FTR_PURR))
-- 
1.7.2.1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/3 RESEND] powerpc: remove cast from void*
  2010-09-28  2:04 ` [PATCH 2/3 RESEND] powerpc: remove cast from void* matt mooney
@ 2010-11-03 14:15   ` Jiri Kosina
  2010-11-03 14:18     ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 3+ messages in thread
From: Jiri Kosina @ 2010-11-03 14:15 UTC (permalink / raw)
  To: matt mooney; +Cc: kernel-janitors, Paul Mackerras, linuxppc-dev

On Mon, 27 Sep 2010, matt mooney wrote:

> Unnecessary cast from void* in assignment.
> 
> Signed-off-by: matt mooney <mfm@muteddisk.com>
> ---
>  arch/powerpc/platforms/pseries/hvCall_inst.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
> index e19ff02..f106662 100644
> --- a/arch/powerpc/platforms/pseries/hvCall_inst.c
> +++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
> @@ -55,7 +55,7 @@ static void hc_stop(struct seq_file *m, void *p)
>  static int hc_show(struct seq_file *m, void *p)
>  {
>  	unsigned long h_num = (unsigned long)p;
> -	struct hcall_stats *hs = (struct hcall_stats *)m->private;
> +	struct hcall_stats *hs = m->private;
>  
>  	if (hs[h_num].num_calls) {
>  		if (cpu_has_feature(CPU_FTR_PURR))

This doesn't seem to be present in 37-rc1, so I am taking it to trivial 
queue. If this has been already merged to another tree, let me know.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH 2/3 RESEND] powerpc: remove cast from void*
  2010-11-03 14:15   ` Jiri Kosina
@ 2010-11-03 14:18     ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 3+ messages in thread
From: Benjamin Herrenschmidt @ 2010-11-03 14:18 UTC (permalink / raw)
  To: Jiri Kosina; +Cc: matt mooney, linuxppc-dev, kernel-janitors, Paul Mackerras

On Wed, 2010-11-03 at 10:15 -0400, Jiri Kosina wrote:
> On Mon, 27 Sep 2010, matt mooney wrote:
> 
> > Unnecessary cast from void* in assignment.
> > 
> > Signed-off-by: matt mooney <mfm@muteddisk.com>
> > ---
> >  arch/powerpc/platforms/pseries/hvCall_inst.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/arch/powerpc/platforms/pseries/hvCall_inst.c b/arch/powerpc/platforms/pseries/hvCall_inst.c
> > index e19ff02..f106662 100644
> > --- a/arch/powerpc/platforms/pseries/hvCall_inst.c
> > +++ b/arch/powerpc/platforms/pseries/hvCall_inst.c
> > @@ -55,7 +55,7 @@ static void hc_stop(struct seq_file *m, void *p)
> >  static int hc_show(struct seq_file *m, void *p)
> >  {
> >  	unsigned long h_num = (unsigned long)p;
> > -	struct hcall_stats *hs = (struct hcall_stats *)m->private;
> > +	struct hcall_stats *hs = m->private;
> >  
> >  	if (hs[h_num].num_calls) {
> >  		if (cpu_has_feature(CPU_FTR_PURR))
> 
> This doesn't seem to be present in 37-rc1, so I am taking it to trivial 
> queue. If this has been already merged to another tree, let me know.

Looks like I missed it, but Ack.

Cheers,
Ben.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2010-11-03 14:18 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <cover.1285638395.git.mfm@muteddisk.com>
2010-09-28  2:04 ` [PATCH 2/3 RESEND] powerpc: remove cast from void* matt mooney
2010-11-03 14:15   ` Jiri Kosina
2010-11-03 14:18     ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).