From: Segher Boessenkool <segher@kernel.crashing.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linuxppc-dev@ozlabs.org, Jon Loeliger <jdl@jdl.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
linux-serial@vger.kernel.org
Subject: Re: 8250.c::autoconfig() fails loopback test on MPC824[15]
Date: Mon, 6 Aug 2007 21:29:55 +0200 [thread overview]
Message-ID: <1288ff079974aa806119584018bab973@kernel.crashing.org> (raw)
In-Reply-To: <200708052357.32650.arnd@arndb.de>
> Maybe the best solution would be for 824[15] to not claim compatibility
> with 8250 at all then.
Or at least it should have a more specific entry for this
"special" 16x50 UART, and that one should be probed first.
> If the device tree contains an entry that matches
> what the generic driver looks for, it better be something that can
> be handled by that driver.
Pretty much; you can't make this rule too strict though,
if a device mostly works with the generic driver, you can
claim compatibility with it -- keep in mind that that can
come back to bite you though, like in this case. The
advantages do outweigh the disadvantages sometimes, it's
all a tradeoff; avoid it if possible.
Segher
next prev parent reply other threads:[~2007-08-06 19:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-04 23:17 8250.c::autoconfig() fails loopback test on MPC824[15] Guennadi Liakhovetski
2007-08-04 23:35 ` Arnd Bergmann
2007-08-05 14:06 ` Guennadi Liakhovetski
2007-08-05 16:41 ` Arnd Bergmann
2007-08-05 21:31 ` Jon Loeliger
2007-08-05 21:39 ` Guennadi Liakhovetski
2007-08-05 21:50 ` Jon Loeliger
2007-08-05 21:57 ` Arnd Bergmann
2007-08-06 19:29 ` Segher Boessenkool [this message]
2007-08-06 19:54 ` Guennadi Liakhovetski
2007-08-06 19:15 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1288ff079974aa806119584018bab973@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=arnd@arndb.de \
--cc=g.liakhovetski@gmx.de \
--cc=jdl@jdl.com \
--cc=linux-serial@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).