From: Michael Ellerman <michael@ellerman.id.au>
To: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
Cc: markn@au1.ibm.com, pmac@au1.ibm.com, tbreeds@au1.ibm.com,
lkessler@us.ibm.com, mjwolf@us.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 3/3] powerpc: Disable VPHN polling during a suspend operation
Date: Wed, 10 Nov 2010 11:58:44 +1100 [thread overview]
Message-ID: <1289350724.22787.12.camel@concordia> (raw)
In-Reply-To: <20101109232514.17098.84090.sendpatchset@manic8ball.ltc.austin.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 689 bytes --]
On Tue, 2010-11-09 at 16:25 -0700, Jesse Larrew wrote:
> From: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
>
> Tie the polling mechanism into the ibm,suspend-me rtas call to
> stop/restart polling before/after a suspend, hibernate, migrate,
> or checkpoint restart operation. This ensures that the system has a
> chance to disable the polling if the partition is migrated to a system
> that does not support VPHN (and vice versa).
I never got round to replying to you about my comments did I. This looks
good, in particular you're right about the error path in
__rtas_suspend_last_cpu(), I was getting muddled trying to read the code
while mentally adding the diff.
cheers
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
prev parent reply other threads:[~2010-11-10 0:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-11-09 23:24 [PATCH V2 0/3][RFC] Add Support for Virtual Processor Home Node (VPHN) Jesse Larrew
2010-11-09 23:24 ` [PATCH V2 1/3] powerpc: Add VPHN firmware feature Jesse Larrew
2010-11-09 23:25 ` [PATCH V2 2/3] powerpc: Poll VPA for topology changes and update NUMA maps Jesse Larrew
2010-11-29 3:44 ` Benjamin Herrenschmidt
2010-12-01 21:50 ` Jesse Larrew
2010-12-01 21:54 ` Benjamin Herrenschmidt
2010-11-09 23:25 ` [PATCH V2 3/3] powerpc: Disable VPHN polling during a suspend operation Jesse Larrew
2010-11-10 0:58 ` Michael Ellerman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1289350724.22787.12.camel@concordia \
--to=michael@ellerman.id.au \
--cc=jlarrew@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=lkessler@us.ibm.com \
--cc=markn@au1.ibm.com \
--cc=mjwolf@us.ibm.com \
--cc=pmac@au1.ibm.com \
--cc=tbreeds@au1.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).