From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 18636B70E8 for ; Thu, 11 Nov 2010 01:39:22 +1100 (EST) Subject: Re: [PATCH] ppc44x:PHY fixup for USB on canyonlands board From: Benjamin Herrenschmidt To: Josh Boyer In-Reply-To: <20101110141914.GC26193@zod.rchland.ibm.com> References: <201011101137.oAABbFoc015547@amcc.com> <20101110141914.GC26193@zod.rchland.ibm.com> Content-Type: text/plain; charset="UTF-8" Date: Thu, 11 Nov 2010 01:38:51 +1100 Message-ID: <1289399931.2147.1392.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Rupjyoti Sarmah , rsarmah@apm.com, linux-kernel@vger.kernel.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, 2010-11-10 at 09:19 -0500, Josh Boyer wrote: > With this being an arch_initcall, it will get called for every kind of > platform in a multi-board kernel. Another reason to only call it from > a > board specific probe function if it really is canyonlands specific. Right. Time to take canyonlands out of ppc4xx_simple and have its own board file again. Do the fixups there. Cheers, Ben.