From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Nishanth Aravamudan <nacc@us.ibm.com>
Cc: sonnyrao@us.ibm.com, miltonm@bga.com,
Paul Mackerras <paulus@samba.org>,
Anton Blanchard <anton@samba.org>,
linuxppc-dev@lists.ozlabs.org
Subject: Re: [RFC PATCH 7/7 v2] ppc: add dynamic dma window support
Date: Thu, 09 Dec 2010 15:17:06 +1100 [thread overview]
Message-ID: <1291868226.16694.220.camel@pasglop> (raw)
In-Reply-To: <1288150518-4026-8-git-send-email-nacc@us.ibm.com>
On Tue, 2010-10-26 at 20:35 -0700, Nishanth Aravamudan wrote:
No much comments... I'm amazed how complex he firmware folks managed to
make this ...
> static int iommu_reconfig_notifier(struct notifier_block *nb, unsigned long action, void *node)
> {
> int err = NOTIFY_OK;
> struct device_node *np = node;
> struct pci_dn *pci = PCI_DN(np);
> + struct direct_window *window;
>
> switch (action) {
> case PSERIES_RECONFIG_REMOVE:
> if (pci && pci->iommu_table)
> iommu_free_table(pci->iommu_table, np->full_name);
> +
> + spin_lock(&direct_window_list_lock);
> + list_for_each_entry(window, &direct_window_list, list) {
> + if (window->device == np) {
> + list_del(&window->list);
> + break;
> + }
> + }
> + spin_unlock(&direct_window_list_lock);
Should you also kfree the window ?
Cheers,
Ben.
next prev parent reply other threads:[~2010-12-09 4:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-27 3:35 [RFC PATCH 0/7 v2] ppc: enable dynamic dma window support Nishanth Aravamudan
2010-10-27 3:35 ` [RFC PATCH 1/7 v2] macio: ensure all dma routines get copied over Nishanth Aravamudan
2010-10-27 3:35 ` [RFC PATCH 2/7 v2] ppc: add memory_hotplug_max Nishanth Aravamudan
2010-10-27 3:35 ` [RFC PATCH 3/7 v2] ppc: do not search for dma-window property on dlpar remove Nishanth Aravamudan
2010-11-29 1:38 ` Benjamin Herrenschmidt
2010-12-01 0:30 ` Nishanth Aravamudan
2010-12-04 0:30 ` Nishanth Aravamudan
2010-10-27 3:35 ` [RFC PATCH 4/7 v2] ppc: checking for pdn->parent is redundant Nishanth Aravamudan
2010-10-27 3:35 ` [RFC PATCH 5/7 v2] ppc/iommu: do not need to check for dma_window == NULL Nishanth Aravamudan
2010-10-27 3:35 ` [RFC PATCH 6/7 v2] ppc/iommu: pass phb only to iommu_table_setparms_lpar Nishanth Aravamudan
2010-12-09 4:24 ` Benjamin Herrenschmidt
2010-12-09 16:16 ` Nishanth Aravamudan
2010-10-27 3:35 ` [RFC PATCH 7/7 v2] ppc: add dynamic dma window support Nishanth Aravamudan
2010-12-09 4:17 ` Benjamin Herrenschmidt [this message]
2010-12-09 19:00 ` Nishanth Aravamudan
2010-12-09 19:09 ` Nishanth Aravamudan
2010-12-11 0:07 ` [PATCH 7/7 v3] " Nishanth Aravamudan
2011-01-08 2:53 ` [PATCH] ppc: update dynamic dma support Nishanth Aravamudan
2011-01-17 17:32 ` [PATCH v2] " Nishanth Aravamudan
2011-01-18 0:20 ` [PATCH v3] " Nishanth Aravamudan
2010-11-08 19:42 ` [RFC PATCH 0/7 v2] ppc: enable dynamic dma window support Nishanth Aravamudan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1291868226.16694.220.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miltonm@bga.com \
--cc=nacc@us.ibm.com \
--cc=paulus@samba.org \
--cc=sonnyrao@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).