From: Dave Kleikamp <shaggy@linux.vnet.ibm.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH V2 4/6] powerpc/44x: don't use tlbivax on AMP systems
Date: Wed, 02 Feb 2011 17:53:59 -0600 [thread overview]
Message-ID: <1296690839.12290.108.camel@shaggy-w500> (raw)
In-Reply-To: <20110202230844.GG3032@yookeroo>
On Thu, 2011-02-03 at 10:08 +1100, David Gibson wrote:
> On Tue, Feb 01, 2011 at 12:48:44PM -0600, Dave Kleikamp wrote:
> > Since other OS's may be running on the other cores don't use tlbivax
>
> [snip]
> > +#ifdef CONFIG_44x
> > +void __init early_init_mmu_44x(void)
> > +{
> > + unsigned long root = of_get_flat_dt_root();
> > + if (of_flat_dt_is_compatible(root, "ibm,47x-AMP"))
> > + amp = 1;
> > +}
> > +#endif /* CONFIG_44x */
>
> A test against a hardcoded compatible string seems a nasty way to do
> this. Maybe we should define a new boolean property for the root
> node.
I'm not crazy about this string, but I needed something in the device
tree to key off of. Freescale has something similar (i.e.
MPC8572DS-CAMP), so I chose to follow their example. I'd be happy to
replace it with a boolean property. Any objection to just using "amp"?
Thanks,
Shaggy
--
Dave Kleikamp
IBM Linux Technology Center
next prev parent reply other threads:[~2011-02-02 23:54 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-01 18:48 [PATCH V2 0/6] powerpc: AMP support for 47x Dave Kleikamp
2011-02-01 18:48 ` [PATCH V2 1/6] powerpc: Move udbg_early_init() after early_init_devtree() Dave Kleikamp
2011-02-02 23:06 ` David Gibson
2011-02-03 0:00 ` Dave Kleikamp
2011-02-07 8:29 ` David Gibson
2011-03-02 3:37 ` Benjamin Herrenschmidt
2011-03-02 13:03 ` Dave Kleikamp
2011-02-01 18:48 ` [PATCH V2 2/6] powerpc/44x: allow override to hard-coded uart address Dave Kleikamp
2011-02-01 18:48 ` [PATCH V2 3/6] powerpc/47x: allow kernel to be loaded in higher physical memory Dave Kleikamp
2011-02-02 7:45 ` Kumar Gala
2011-02-09 22:59 ` Dave Kleikamp
2011-02-01 18:48 ` [PATCH V2 4/6] powerpc/44x: don't use tlbivax on AMP systems Dave Kleikamp
2011-02-02 7:48 ` Kumar Gala
2011-02-02 13:19 ` Dave Kleikamp
2011-02-02 23:08 ` David Gibson
2011-02-02 23:53 ` Dave Kleikamp [this message]
2011-02-03 5:03 ` David Gibson
2011-02-03 23:15 ` Dave Kleikamp
2011-02-04 2:22 ` Timur Tabi
2011-02-07 8:30 ` David Gibson
2011-02-04 13:56 ` Josh Boyer
2011-02-04 14:44 ` Dave Kleikamp
2011-02-01 18:48 ` [PATCH V2 5/6] powerpc/44x: boot wrapper: allow kernel to load into non-zero address Dave Kleikamp
2011-02-01 19:13 ` Scott Wood
2011-02-01 19:41 ` Dave Kleikamp
2011-02-04 14:07 ` Josh Boyer
2011-02-04 14:44 ` Dave Kleikamp
2011-02-01 18:48 ` [PATCH V2 6/6] powerpc/476: Create a dts files for two 476 AMP instances under ISS Dave Kleikamp
2011-02-02 2:43 ` David Gibson
2011-02-09 23:03 ` Dave Kleikamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1296690839.12290.108.camel@shaggy-w500 \
--to=shaggy@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox