From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Tseng-Hui (Frank) Lin" <thlin@linux.vnet.ibm.com>
Cc: tsenglin@us.ibm.com, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v2 3/3] powerpc: Add IO event interrupt support
Date: Mon, 07 Feb 2011 16:10:37 +1100 [thread overview]
Message-ID: <1297055437.14982.57.camel@pasglop> (raw)
In-Reply-To: <1294267483.24377.30.camel@flin.austin.ibm.com>
On Wed, 2011-01-05 at 16:44 -0600, Tseng-Hui (Frank) Lin wrote:
> This patch adds support for handling IO Event interrupts which come
> through at the /event-sources/ibm,io-events device tree node.
.../...
The previous patches regarding the error log sometimes call it error log
and sometimes event log. Can you consolidate that ?
> +int pseries_ioei_register_handler(pseries_ioei_handler_t handler)
> +{
Shouldn't we have a void * to attach with each client so it can put
its private data there and get them back in the handler ?
We are -really- re-inventing interrupts and/or notifiers here, which
I find a tad annoying..
Cheers,
Ben.
next prev parent reply other threads:[~2011-02-07 5:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-05 22:44 [PATCH v2 3/3] powerpc: Add IO event interrupt support Tseng-Hui (Frank) Lin
2011-02-07 5:10 ` Benjamin Herrenschmidt [this message]
2011-02-07 21:40 ` Tseng-Hui (Frank) Lin
2011-02-07 21:46 ` Benjamin Herrenschmidt
2011-02-08 14:29 ` Tseng-Hui (Frank) Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297055437.14982.57.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=thlin@linux.vnet.ibm.com \
--cc=tsenglin@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).