From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: prasad@linux.vnet.ibm.com
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
David Kleikamp <shaggy@us.ibm.com>
Subject: Re: [PATCH] powerpc: Fix call to flush_ptrace_hw_breakpoint()
Date: Mon, 07 Feb 2011 16:13:37 +1100 [thread overview]
Message-ID: <1297055617.14982.59.camel@pasglop> (raw)
In-Reply-To: <20110207045230.GB4287@in.ibm.com>
On Mon, 2011-02-07 at 10:22 +0530, K.Prasad wrote:
> Okay! Another wrapper of "#ifndef CONFIG_HAVE_HW_BREAKPOINT" around
> the
> definition of 'set_debug_reg_defaults'.
Can you send a patch ?
> There's indeed too much sprinkling of #ifdefs in the code, but most of
> it would go away when the BookE code also uses the generic
> hw-breakpoint interfaces.
What's your status for those patches ?
> Given the advanced debug features that BookE supports, it's
> unfortunately not that straight-forward (needs additions to generic
> hw-breakpoint infrastructure).
Might want to move a lot of that code to a separate set of files maybe
and just call a single hook from the various process.c locations ?
Cheers,
Ben.
next prev parent reply other threads:[~2011-02-07 6:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-02-06 22:54 [PATCH] powerpc: Fix call to flush_ptrace_hw_breakpoint() Benjamin Herrenschmidt
2011-02-07 2:56 ` K.Prasad
2011-02-07 3:10 ` Benjamin Herrenschmidt
2011-02-07 4:52 ` K.Prasad
2011-02-07 5:13 ` Benjamin Herrenschmidt [this message]
2011-02-10 14:44 ` K.Prasad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1297055617.14982.59.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=prasad@linux.vnet.ibm.com \
--cc=shaggy@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).