* [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module
@ 2011-02-20 21:38 Linux User #330250
2011-02-21 8:37 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Linux User #330250 @ 2011-02-20 21:38 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Takashi Iwai, Johannes Berg
Hello again!
Sorry for sending the patch three times. (This is the fourth...)
About the sign-off: I use the name I've been using since I started
participating. The document $LINUX/Documentation/SubmittingPatches clearly
states that one has to use real names. I'm breaking this rule, but I'm not
ready to reveal my real name here or at any other place at this time. Sorry.
If this patch is not accepted due to this, well=E2=80=A6 that's life. BTW m=
y real
given name is Andreas.
So, here's the patch, this time with a (pseudonym) sign-off:
This patch makes the snd-aoa ALSA sound module support the TAS3001C codec o=
f=20
my Apple Power Mac G4 "Quicksilver" (2001 model). I suppose it will also wo=
rk=20
for the "Quicksilver 2002", since both identify as PowerMac3,5.
The patch also changes a few comments to name the exact Power Mac model mor=
e=20
accurately in sound/aoa/fabrics/layout.c.
Signed-off-by: Andreas aka Linux User #330250 <linuxuser330250@gmx.net>
=2D--
diff -Naur linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c linux-2.6.38-rc=
5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c
=2D-- linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c 2011-01-05 01:50:=
19.000000000 +0100
+++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c 201=
1-02-17 18:43:26.000000000 +0100
@@ -111,6 +111,7 @@
MODULE_ALIAS("sound-layout-100");
=20
MODULE_ALIAS("aoa-device-id-14");
+MODULE_ALIAS("aoa-device-id-21");
MODULE_ALIAS("aoa-device-id-22");
MODULE_ALIAS("aoa-device-id-35");
=20
@@ -333,14 +334,14 @@
.connections =3D topaz_input,
},
},
=2D /* Quad PowerMac (analog in, analog/digital out) */
+ /* PowerMac11,2 (G5 Dual-Core and Quad) (analog in, analog/digital =
out) */
{ .layout_id =3D 68,
.codecs[0] =3D {
.name =3D "onyx",
.connections =3D onyx_connections_nomic,
},
},
=2D /* Quad PowerMac (digital in) */
+ /* PowerMac11,2 (G5 Dual-Core and Quad) (digital in) */
{ .layout_id =3D 69,
.codecs[0] =3D {
.name =3D "topaz",
@@ -521,14 +522,21 @@
.connections =3D onyx_connections_noheadphones,
},
},---
=2D /* PowerMac3,4 */
+ /* PowerMac3,4 (Digital Audio) */
{ .device_id =3D 14,
.codecs[0] =3D {
.name =3D "tas",
.connections =3D tas_connections_noline,
},
},
=2D /* PowerMac3,6 */
+ /* PowerMac3,5 (Quicksilver) */
+ { .device_id =3D 21,
+ .codecs[0] =3D {
+ .name =3D "tas",
+ .connections =3D tas_connections_noline,
+ },
+ },
+ /* PowerMac3,6 (Mirrored Drive Doors) */
{ .device_id =3D 22,
.codecs[0] =3D {
.name =3D "tas",
diff -Naur linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c linux-2.6=
=2E38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c
=2D-- linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c 2011-01-0=
5 01:50:19.000000000 +0100
+++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c =
2011-02-17 18:44:36.000000000 +0100
@@ -200,7 +200,7 @@
* We probably cannot handle all device-id machines,
* so restrict to those we do handle for now.
*/
=2D if (id && (*id =3D=3D 22 || *id =3D=3D 14 || *id =
=3D=3D 35)) {
+ if (id && (*id =3D=3D 22 || *id =3D=3D 21 || *id =
=3D=3D 14 || *id =3D=3D 35)) {
snprintf(dev->sound.modalias, 32,
"aoa-device-id-%d", *id);
ok =3D 1;
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module
2011-02-20 21:38 [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module Linux User #330250
@ 2011-02-21 8:37 ` Takashi Iwai
2011-02-21 22:20 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 8+ messages in thread
From: Takashi Iwai @ 2011-02-21 8:37 UTC (permalink / raw)
To: Linux User #330250; +Cc: Johannes Berg, linuxppc-dev
At Sun, 20 Feb 2011 22:38:28 +0100,
Linux User #330250 wrote:
>
> Hello again!
>
> Sorry for sending the patch three times. (This is the fourth...)
>
> About the sign-off: I use the name I've been using since I started
> participating. The document $LINUX/Documentation/SubmittingPatches clearly
> states that one has to use real names. I'm breaking this rule, but I'm not
> ready to reveal my real name here or at any other place at this time. Sorry.
> If this patch is not accepted due to this, well… that's life. BTW my real
> given name is Andreas.
Well, we need really the full name for sign-off.
In general, it's not acceptable with the proper sign-off...
Takashi
>
>
> So, here's the patch, this time with a (pseudonym) sign-off:
>
> This patch makes the snd-aoa ALSA sound module support the TAS3001C codec of
> my Apple Power Mac G4 "Quicksilver" (2001 model). I suppose it will also work
> for the "Quicksilver 2002", since both identify as PowerMac3,5.
>
> The patch also changes a few comments to name the exact Power Mac model more
> accurately in sound/aoa/fabrics/layout.c.
>
> Signed-off-by: Andreas aka Linux User #330250 <linuxuser330250@gmx.net>
>
> ---
>
> diff -Naur linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c
> --- linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c 2011-01-05 01:50:19.000000000 +0100
> +++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c 2011-02-17 18:43:26.000000000 +0100
> @@ -111,6 +111,7 @@
> MODULE_ALIAS("sound-layout-100");
>
> MODULE_ALIAS("aoa-device-id-14");
> +MODULE_ALIAS("aoa-device-id-21");
> MODULE_ALIAS("aoa-device-id-22");
> MODULE_ALIAS("aoa-device-id-35");
>
> @@ -333,14 +334,14 @@
> .connections = topaz_input,
> },
> },
> - /* Quad PowerMac (analog in, analog/digital out) */
> + /* PowerMac11,2 (G5 Dual-Core and Quad) (analog in, analog/digital out) */
> { .layout_id = 68,
> .codecs[0] = {
> .name = "onyx",
> .connections = onyx_connections_nomic,
> },
> },
> - /* Quad PowerMac (digital in) */
> + /* PowerMac11,2 (G5 Dual-Core and Quad) (digital in) */
> { .layout_id = 69,
> .codecs[0] = {
> .name = "topaz",
> @@ -521,14 +522,21 @@
> .connections = onyx_connections_noheadphones,
> },
> },---
> - /* PowerMac3,4 */
> + /* PowerMac3,4 (Digital Audio) */
> { .device_id = 14,
> .codecs[0] = {
> .name = "tas",
> .connections = tas_connections_noline,
> },
> },
> - /* PowerMac3,6 */
> + /* PowerMac3,5 (Quicksilver) */
> + { .device_id = 21,
> + .codecs[0] = {
> + .name = "tas",
> + .connections = tas_connections_noline,
> + },
> + },
> + /* PowerMac3,6 (Mirrored Drive Doors) */
> { .device_id = 22,
> .codecs[0] = {
> .name = "tas",
> diff -Naur linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c
> --- linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c 2011-01-05 01:50:19.000000000 +0100
> +++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c 2011-02-17 18:44:36.000000000 +0100
> @@ -200,7 +200,7 @@
> * We probably cannot handle all device-id machines,
> * so restrict to those we do handle for now.
> */
> - if (id && (*id == 22 || *id == 14 || *id == 35)) {
> + if (id && (*id == 22 || *id == 21 || *id == 14 || *id == 35)) {
> snprintf(dev->sound.modalias, 32,
> "aoa-device-id-%d", *id);
> ok = 1;
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module
2011-02-21 8:37 ` Takashi Iwai
@ 2011-02-21 22:20 ` Benjamin Herrenschmidt
2011-02-23 17:56 ` Linux User #330250
0 siblings, 1 reply; 8+ messages in thread
From: Benjamin Herrenschmidt @ 2011-02-21 22:20 UTC (permalink / raw)
To: Takashi Iwai; +Cc: Johannes Berg, linuxppc-dev
On Mon, 2011-02-21 at 09:37 +0100, Takashi Iwai wrote:
> At Sun, 20 Feb 2011 22:38:28 +0100,
> Linux User #330250 wrote:
> >
> > Hello again!
> >
> > Sorry for sending the patch three times. (This is the fourth...)
> >
> > About the sign-off: I use the name I've been using since I started
> > participating. The document $LINUX/Documentation/SubmittingPatches clearly
> > states that one has to use real names. I'm breaking this rule, but I'm not
> > ready to reveal my real name here or at any other place at this time. Sorry.
> > If this patch is not accepted due to this, well… that's life. BTW my real
> > given name is Andreas.
>
> Well, we need really the full name for sign-off.
> In general, it's not acceptable with the proper sign-off...
So somebody else can just pick the "documentation" that layout ID 21
works just like 22 for us, and write an "acceptable" patch...
Cheers,
Ben.
>
> Takashi
>
>
> >
> >
> > So, here's the patch, this time with a (pseudonym) sign-off:
> >
> > This patch makes the snd-aoa ALSA sound module support the TAS3001C codec of
> > my Apple Power Mac G4 "Quicksilver" (2001 model). I suppose it will also work
> > for the "Quicksilver 2002", since both identify as PowerMac3,5.
> >
> > The patch also changes a few comments to name the exact Power Mac model more
> > accurately in sound/aoa/fabrics/layout.c.
> >
> > Signed-off-by: Andreas aka Linux User #330250 <linuxuser330250@gmx.net>
> >
> > ---
> >
> > diff -Naur linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c
> > --- linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c 2011-01-05 01:50:19.000000000 +0100
> > +++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c 2011-02-17 18:43:26.000000000 +0100
> > @@ -111,6 +111,7 @@
> > MODULE_ALIAS("sound-layout-100");
> >
> > MODULE_ALIAS("aoa-device-id-14");
> > +MODULE_ALIAS("aoa-device-id-21");
> > MODULE_ALIAS("aoa-device-id-22");
> > MODULE_ALIAS("aoa-device-id-35");
> >
> > @@ -333,14 +334,14 @@
> > .connections = topaz_input,
> > },
> > },
> > - /* Quad PowerMac (analog in, analog/digital out) */
> > + /* PowerMac11,2 (G5 Dual-Core and Quad) (analog in, analog/digital out) */
> > { .layout_id = 68,
> > .codecs[0] = {
> > .name = "onyx",
> > .connections = onyx_connections_nomic,
> > },
> > },
> > - /* Quad PowerMac (digital in) */
> > + /* PowerMac11,2 (G5 Dual-Core and Quad) (digital in) */
> > { .layout_id = 69,
> > .codecs[0] = {
> > .name = "topaz",
> > @@ -521,14 +522,21 @@
> > .connections = onyx_connections_noheadphones,
> > },
> > },---
> > - /* PowerMac3,4 */
> > + /* PowerMac3,4 (Digital Audio) */
> > { .device_id = 14,
> > .codecs[0] = {
> > .name = "tas",
> > .connections = tas_connections_noline,
> > },
> > },
> > - /* PowerMac3,6 */
> > + /* PowerMac3,5 (Quicksilver) */
> > + { .device_id = 21,
> > + .codecs[0] = {
> > + .name = "tas",
> > + .connections = tas_connections_noline,
> > + },
> > + },
> > + /* PowerMac3,6 (Mirrored Drive Doors) */
> > { .device_id = 22,
> > .codecs[0] = {
> > .name = "tas",
> > diff -Naur linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c
> > --- linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c 2011-01-05 01:50:19.000000000 +0100
> > +++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c 2011-02-17 18:44:36.000000000 +0100
> > @@ -200,7 +200,7 @@
> > * We probably cannot handle all device-id machines,
> > * so restrict to those we do handle for now.
> > */
> > - if (id && (*id == 22 || *id == 14 || *id == 35)) {
> > + if (id && (*id == 22 || *id == 21 || *id == 14 || *id == 35)) {
> > snprintf(dev->sound.modalias, 32,
> > "aoa-device-id-%d", *id);
> > ok = 1;
> >
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module
2011-02-21 22:20 ` Benjamin Herrenschmidt
@ 2011-02-23 17:56 ` Linux User #330250
0 siblings, 0 replies; 8+ messages in thread
From: Linux User #330250 @ 2011-02-23 17:56 UTC (permalink / raw)
To: linuxppc-dev
---------- Original message ----------
Subject: Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module
Date: Montag, 21. Februar 2011N
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Takashi Iwai <tiwai@suse.de>
> So somebody else can just pick the "documentation" that layout ID 21
> works just like 22 for us, and write an "acceptable" patch...
Actually, the G4 "Quicksilver" PowerMac3,5 is propably more alike to the G4
"Digital Audio" PowerMac3,4 in this regard. The device ID on the Digital Audio
is decimal 14. The Quicksilver is decimal 21.
PowerMac3,4 Digital Audio: Device ID 14, ??? chip
PowerMac3,5 Quicksilver: Device ID 21, TAS 3001C CODEC chip
PowerMac3,6 Mirrored Drive Doors: Device ID 22, TAS3004 CODEC chip
$LINUX/sound/aoa/codecs/tas.c driver was originally made for the TAS3004,
which I figure because only "tas 3004" is mentioned in the source, no other.
Since the Quicksilver, which is newer than the Digital Audio, doesn't have the
TAS3004 chip (Mac OS X System Profiler states "Texas Intruments TAS3001C"), but
the Digital Audio seemed to work fine with the aoa-tas codec too (it's already
in the kernel) I tried it with the Quicksilver as well.
The modules loads without errors, the sound card is listed
(/proc/asound/cards) and the volume controls are usable.
I played some sound and everything seemed to work fine. So I submitted the
patch.
So now I have to appologize. And I'm glad the patch hasn't been accepted. Why?
Because I had booted with the wrong kernel when I tested if the sound played
okay. I must have still used the powermac sound module, not aoa.
BIG APPOLOGIES.
I tested again yesterday and today and can't get it to play a sound. I also
checked the logs and all the ALSA stuff (in /proc/asound). Everything seems
okay. I then tried a different mixer: pavucontrol -- because I have trouble to
unmute without this on my PC too.
Now the surprise: it won't let me unmute.
Maybe it's just my system. I use Gentoo Linux and just recently updated the
whole system to use Pulse Audio.
If anyone else could try the patch or write a new one on their G4 Quicksilvers
I'd be happy.
And: I do understand the sign-off limiting to real names. It's a good thing.
Cheers,
Andreas aka Mac User #330250
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module
@ 2011-02-19 14:53 Linux User #330250
2011-02-20 9:13 ` Takashi Iwai
0 siblings, 1 reply; 8+ messages in thread
From: Linux User #330250 @ 2011-02-19 14:53 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Takashi Iwai, Johannes Berg
Hello!
About two years ago Johannes Berg wrote support for the PowerMac3,6 aka G4 =
MDD=20
which I was using as a desktop computer then. Johannes wrote all the code, =
and=20
I tested it.
I now have a PowerMac3,5 =E2=80=93 yes, an earlier model.
This patch makes the snd-aoa ALSA sound module support the TAS3001C codec o=
f=20
my Apple Power Mac G4 "Quicksilver" (2001 model). I suppose it will also wo=
rk=20
for the "Quicksilver 2002", since both identify as PowerMac3,5.
The patch also changes a few comments to name the exact Power Mac model mor=
e=20
accurately in sound/aoa/fabrics/layout.c.
This is my first contribution to the linux kernel ever, so I hope you will =
be=20
kind to me. I am not a programmer, but adding already supported devices was=
a=20
task even I could accomplish.
Thanks,
Andreas aka Linux User #330250
=2D--
diff -Naur linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c linux-2.6.38-rc=
5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c
=2D-- linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c 2011-01-05 01:50:=
19.000000000 +0100
+++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c 201=
1-02-17 18:43:26.000000000 +0100
@@ -111,6 +111,7 @@
MODULE_ALIAS("sound-layout-100");
=20
MODULE_ALIAS("aoa-device-id-14");
+MODULE_ALIAS("aoa-device-id-21");
MODULE_ALIAS("aoa-device-id-22");
MODULE_ALIAS("aoa-device-id-35");
=20
@@ -333,14 +334,14 @@
.connections =3D topaz_input,
},
},
=2D /* Quad PowerMac (analog in, analog/digital out) */
+ /* PowerMac11,2 (G5 Dual-Core and Quad) (analog in, analog/digital =
out) */
{ .layout_id =3D 68,
.codecs[0] =3D {
.name =3D "onyx",
.connections =3D onyx_connections_nomic,
},
},
=2D /* Quad PowerMac (digital in) */
+ /* PowerMac11,2 (G5 Dual-Core and Quad) (digital in) */
{ .layout_id =3D 69,
.codecs[0] =3D {
.name =3D "topaz",
@@ -521,14 +522,21 @@
.connections =3D onyx_connections_noheadphones,
},
},---
=2D /* PowerMac3,4 */
+ /* PowerMac3,4 (Digital Audio) */
{ .device_id =3D 14,
.codecs[0] =3D {
.name =3D "tas",
.connections =3D tas_connections_noline,
},
},
=2D /* PowerMac3,6 */
+ /* PowerMac3,5 (Quicksilver) */
+ { .device_id =3D 21,
+ .codecs[0] =3D {
+ .name =3D "tas",
+ .connections =3D tas_connections_noline,
+ },
+ },
+ /* PowerMac3,6 (Mirrored Drive Doors) */
{ .device_id =3D 22,
.codecs[0] =3D {
.name =3D "tas",
diff -Naur linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c linux-2.6=
=2E38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c
=2D-- linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c 2011-01-0=
5 01:50:19.000000000 +0100
+++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c =
2011-02-17 18:44:36.000000000 +0100
@@ -200,7 +200,7 @@
* We probably cannot handle all device-id machines,
* so restrict to those we do handle for now.
*/
=2D if (id && (*id =3D=3D 22 || *id =3D=3D 14 || *id =
=3D=3D 35)) {
+ if (id && (*id =3D=3D 22 || *id =3D=3D 21 || *id =
=3D=3D 14 || *id =3D=3D 35)) {
snprintf(dev->sound.modalias, 32,
"aoa-device-id-%d", *id);
ok =3D 1;
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module
2011-02-19 14:53 Linux User #330250
@ 2011-02-20 9:13 ` Takashi Iwai
0 siblings, 0 replies; 8+ messages in thread
From: Takashi Iwai @ 2011-02-20 9:13 UTC (permalink / raw)
To: Linux User #330250; +Cc: Johannes Berg, linuxppc-dev
At Sat, 19 Feb 2011 15:53:46 +0100,
Linux User #330250 wrote:
>
> Hello!
>
> About two years ago Johannes Berg wrote support for the PowerMac3,6 aka G4 MDD
> which I was using as a desktop computer then. Johannes wrote all the code, and
> I tested it.
>
> I now have a PowerMac3,5 – yes, an earlier model.
>
> This patch makes the snd-aoa ALSA sound module support the TAS3001C codec of
> my Apple Power Mac G4 "Quicksilver" (2001 model). I suppose it will also work
> for the "Quicksilver 2002", since both identify as PowerMac3,5.
>
> The patch also changes a few comments to name the exact Power Mac model more
> accurately in sound/aoa/fabrics/layout.c.
>
> This is my first contribution to the linux kernel ever, so I hope you will be
> kind to me. I am not a programmer, but adding already supported devices was a
> task even I could accomplish.
Thanks for the patch. The changes look good to me.
The only missing piece is your sign-off. Could you give it?
See $LINUX/Documentation/SubmittingPatches section "Sign your work"
for details.
Takashi
>
> Thanks,
> Andreas aka Linux User #330250
>
> ---
>
> diff -Naur linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c
> --- linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c 2011-01-05 01:50:19.000000000 +0100
> +++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c 2011-02-17 18:43:26.000000000 +0100
> @@ -111,6 +111,7 @@
> MODULE_ALIAS("sound-layout-100");
>
> MODULE_ALIAS("aoa-device-id-14");
> +MODULE_ALIAS("aoa-device-id-21");
> MODULE_ALIAS("aoa-device-id-22");
> MODULE_ALIAS("aoa-device-id-35");
>
> @@ -333,14 +334,14 @@
> .connections = topaz_input,
> },
> },
> - /* Quad PowerMac (analog in, analog/digital out) */
> + /* PowerMac11,2 (G5 Dual-Core and Quad) (analog in, analog/digital out) */
> { .layout_id = 68,
> .codecs[0] = {
> .name = "onyx",
> .connections = onyx_connections_nomic,
> },
> },
> - /* Quad PowerMac (digital in) */
> + /* PowerMac11,2 (G5 Dual-Core and Quad) (digital in) */
> { .layout_id = 69,
> .codecs[0] = {
> .name = "topaz",
> @@ -521,14 +522,21 @@
> .connections = onyx_connections_noheadphones,
> },
> },---
> - /* PowerMac3,4 */
> + /* PowerMac3,4 (Digital Audio) */
> { .device_id = 14,
> .codecs[0] = {
> .name = "tas",
> .connections = tas_connections_noline,
> },
> },
> - /* PowerMac3,6 */
> + /* PowerMac3,5 (Quicksilver) */
> + { .device_id = 21,
> + .codecs[0] = {
> + .name = "tas",
> + .connections = tas_connections_noline,
> + },
> + },
> + /* PowerMac3,6 (Mirrored Drive Doors) */
> { .device_id = 22,
> .codecs[0] = {
> .name = "tas",
> diff -Naur linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c
> --- linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c 2011-01-05 01:50:19.000000000 +0100
> +++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c 2011-02-17 18:44:36.000000000 +0100
> @@ -200,7 +200,7 @@
> * We probably cannot handle all device-id machines,
> * so restrict to those we do handle for now.
> */
> - if (id && (*id == 22 || *id == 14 || *id == 35)) {
> + if (id && (*id == 22 || *id == 21 || *id == 14 || *id == 35)) {
> snprintf(dev->sound.modalias, 32,
> "aoa-device-id-%d", *id);
> ok = 1;
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module
@ 2011-02-17 20:53 Linux User #330250
0 siblings, 0 replies; 8+ messages in thread
From: Linux User #330250 @ 2011-02-17 20:53 UTC (permalink / raw)
To: linuxppc-dev
Hello!
About two years ago Johannes Berg wrote support for the PowerMac3,6 aka G4 =
MDD=20
which I was using as a desktop computer then. Johannes wrote all the code, =
and=20
I tested it.
I now have a PowerMac3,5 =E2=80=93 yes, an earlier model.
This patch makes the snd-aoa ALSA sound module support the TAS3001C codec o=
f=20
my Apple Power Mac G4 "Quicksilver" (2001 model). I suppose it will also wo=
rk=20
for the "Quicksilver 2002", since both identify as PowerMac3,5.
The patch also changes a few comments to name the exact Power Mac model mor=
e=20
accurately in sound/aoa/fabrics/layout.c.
This is my first contribution to the linux kernel ever, so I hope you will =
be=20
kind to me. I am not a programmer, but adding already supported devices was=
a=20
task even I could accomplish.
Thanks,
Andreas aka Linux User #330250
=2D--
diff -Naur linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c linux-2.6.38-rc=
5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c
=2D-- linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c 2011-01-05 01:50:=
19.000000000 +0100
+++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c 201=
1-02-17 18:43:26.000000000 +0100
@@ -111,6 +111,7 @@
MODULE_ALIAS("sound-layout-100");
=20
MODULE_ALIAS("aoa-device-id-14");
+MODULE_ALIAS("aoa-device-id-21");
MODULE_ALIAS("aoa-device-id-22");
MODULE_ALIAS("aoa-device-id-35");
=20
@@ -333,14 +334,14 @@
.connections =3D topaz_input,
},
},
=2D /* Quad PowerMac (analog in, analog/digital out) */
+ /* PowerMac11,2 (G5 Dual-Core and Quad) (analog in, analog/digital =
out) */
{ .layout_id =3D 68,
.codecs[0] =3D {
.name =3D "onyx",
.connections =3D onyx_connections_nomic,
},
},
=2D /* Quad PowerMac (digital in) */
+ /* PowerMac11,2 (G5 Dual-Core and Quad) (digital in) */
{ .layout_id =3D 69,
.codecs[0] =3D {
.name =3D "topaz",
@@ -521,14 +522,21 @@
.connections =3D onyx_connections_noheadphones,
},
},---
=2D /* PowerMac3,4 */
+ /* PowerMac3,4 (Digital Audio) */
{ .device_id =3D 14,
.codecs[0] =3D {
.name =3D "tas",
.connections =3D tas_connections_noline,
},
},
=2D /* PowerMac3,6 */
+ /* PowerMac3,5 (Quicksilver) */
+ { .device_id =3D 21,
+ .codecs[0] =3D {
+ .name =3D "tas",
+ .connections =3D tas_connections_noline,
+ },
+ },
+ /* PowerMac3,6 (Mirrored Drive Doors) */
{ .device_id =3D 22,
.codecs[0] =3D {
.name =3D "tas",
diff -Naur linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c linux-2.6=
=2E38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c
=2D-- linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c 2011-01-0=
5 01:50:19.000000000 +0100
+++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c =
2011-02-17 18:44:36.000000000 +0100
@@ -200,7 +200,7 @@
* We probably cannot handle all device-id machines,
* so restrict to those we do handle for now.
*/
=2D if (id && (*id =3D=3D 22 || *id =3D=3D 14 || *id =
=3D=3D 35)) {
+ if (id && (*id =3D=3D 22 || *id =3D=3D 21 || *id =
=3D=3D 14 || *id =3D=3D 35)) {
snprintf(dev->sound.modalias, 32,
"aoa-device-id-%d", *id);
ok =3D 1;
^ permalink raw reply [flat|nested] 8+ messages in thread* [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module
@ 2011-02-17 20:17 Linux User #330250
0 siblings, 0 replies; 8+ messages in thread
From: Linux User #330250 @ 2011-02-17 20:17 UTC (permalink / raw)
To: linuxppc-dev
[-- Attachment #1: Type: Text/Plain, Size: 831 bytes --]
Hello!
About two years ago Johannes Berg wrote support for the PowerMac3,6 aka G4 MDD
which I was using as a desktop computer then. Johannes wrote all the code, and
I tested it.
I now have a PowerMac3,5 – yes, an earlier model.
This patch makes the snd-aoa ALSA sound module support the TAS3001C codec of
my Apple Power Mac G4 "Quicksilver" (2001 model). I suppose it will also work
for the "Quicksilver 2002", since both identify as PowerMac3,5.
The patch also changes a few comments to name the exact Power Mac model more
accurately in sound/aoa/fabrics/layout.c.
This is my first contribution to the linux kernel ever, so I hope you will be
kind to me. I am not a programmer, but adding already supported devices was a
task even I could accomplish.
Thanks,
Andreas aka Linux User #330250
[-- Attachment #2: Quicksilver-aoa.patch --]
[-- Type: text/x-patch, Size: 2692 bytes --]
diff -Naur linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c
--- linux-2.6.38-rc5-git2/sound/aoa/fabrics/layout.c 2011-01-05 01:50:19.000000000 +0100
+++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/fabrics/layout.c 2011-02-17 18:43:26.000000000 +0100
@@ -111,6 +111,7 @@
MODULE_ALIAS("sound-layout-100");
MODULE_ALIAS("aoa-device-id-14");
+MODULE_ALIAS("aoa-device-id-21");
MODULE_ALIAS("aoa-device-id-22");
MODULE_ALIAS("aoa-device-id-35");
@@ -333,14 +334,14 @@
.connections = topaz_input,
},
},
- /* Quad PowerMac (analog in, analog/digital out) */
+ /* PowerMac11,2 (G5 Dual-Core and Quad) (analog in, analog/digital out) */
{ .layout_id = 68,
.codecs[0] = {
.name = "onyx",
.connections = onyx_connections_nomic,
},
},
- /* Quad PowerMac (digital in) */
+ /* PowerMac11,2 (G5 Dual-Core and Quad) (digital in) */
{ .layout_id = 69,
.codecs[0] = {
.name = "topaz",
@@ -521,14 +522,21 @@
.connections = onyx_connections_noheadphones,
},
},
- /* PowerMac3,4 */
+ /* PowerMac3,4 (Digital Audio) */
{ .device_id = 14,
.codecs[0] = {
.name = "tas",
.connections = tas_connections_noline,
},
},
- /* PowerMac3,6 */
+ /* PowerMac3,5 (Quicksilver) */
+ { .device_id = 21,
+ .codecs[0] = {
+ .name = "tas",
+ .connections = tas_connections_noline,
+ },
+ },
+ /* PowerMac3,6 (Mirrored Drive Doors) */
{ .device_id = 22,
.codecs[0] = {
.name = "tas",
diff -Naur linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c
--- linux-2.6.38-rc5-git2/sound/aoa/soundbus/i2sbus/core.c 2011-01-05 01:50:19.000000000 +0100
+++ linux-2.6.38-rc5-git2-aoa-PowerMac3,5/sound/aoa/soundbus/i2sbus/core.c 2011-02-17 18:44:36.000000000 +0100
@@ -200,7 +200,7 @@
* We probably cannot handle all device-id machines,
* so restrict to those we do handle for now.
*/
- if (id && (*id == 22 || *id == 14 || *id == 35)) {
+ if (id && (*id == 22 || *id == 21 || *id == 14 || *id == 35)) {
snprintf(dev->sound.modalias, 32,
"aoa-device-id-%d", *id);
ok = 1;
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2011-02-23 17:56 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-02-20 21:38 [PATCH] Add support for PowerMac3,5 in snd-aoa ALSA sound module Linux User #330250
2011-02-21 8:37 ` Takashi Iwai
2011-02-21 22:20 ` Benjamin Herrenschmidt
2011-02-23 17:56 ` Linux User #330250
-- strict thread matches above, loose matches on Subject: below --
2011-02-19 14:53 Linux User #330250
2011-02-20 9:13 ` Takashi Iwai
2011-02-17 20:53 Linux User #330250
2011-02-17 20:17 Linux User #330250
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).