From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: linuxppc-dev@lists.ozlabs.org,
Jeremy Fitzhardinge <jeremy@goop.org>,
Hugh Dickins <hughd@google.com>,
linux-kernel@vger.kernel.org
Subject: Re: PowerPC BUG: using smp_processor_id() in preemptible code
Date: Fri, 25 Feb 2011 08:23:26 +1100 [thread overview]
Message-ID: <1298582606.8833.509.camel@pasglop> (raw)
In-Reply-To: <1298581675.5226.840.camel@laptop>
On Thu, 2011-02-24 at 22:07 +0100, Peter Zijlstra wrote:
>
> Lovely problem :-), benh mentioned it on IRC, but I never got around
> to
> finding the email thread, thanks for the CC.
>
> > What would be better for 2.6.38 and 2.6.37-stable? Moving that call
> to
> > vunmap_page_range back under vb->lock, or the partial-Peter-patch
> below?
> > And then what should be done for 2.6.39?
>
> I think you'll also need the arch/powerpc/kernel/process.c changes
> that
> cause context switches to flush the tlb_batch queues.
I don't think that's needed here as there shall be no batching happening
on the vmalloc space, but it can't hurt to merge it regardless :-)
Cheers,
Ben.
next prev parent reply other threads:[~2011-02-24 21:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-12-29 22:54 PowerPC BUG: using smp_processor_id() in preemptible code Hugh Dickins
2010-12-30 1:26 ` Jeremy Fitzhardinge
2010-12-30 10:45 ` Benjamin Herrenschmidt
2011-02-24 20:47 ` Hugh Dickins
2011-02-24 21:07 ` Peter Zijlstra
2011-02-24 21:23 ` Benjamin Herrenschmidt [this message]
2011-02-24 21:27 ` Peter Zijlstra
2011-02-24 21:12 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1298582606.8833.509.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=a.p.zijlstra@chello.nl \
--cc=hughd@google.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).