linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>,
	linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jesse Larrew <jlarrew@linux.vnet.ibm.com>
Subject: Re: [BUG] rebuild_sched_domains considered dangerous
Date: Wed, 09 Mar 2011 12:33:49 +0100	[thread overview]
Message-ID: <1299670429.2308.2834.camel@twins> (raw)
In-Reply-To: <1299665998.2308.2753.camel@twins>

On Wed, 2011-03-09 at 11:19 +0100, Peter Zijlstra wrote:
> > It appears that this corresponds to one CPU deciding to rebuild the
> > sched domains. There's various reasons why that can happen, the typical
> > one in our case is the new VPNH feature where the hypervisor informs us
> > of a change in node affinity of our virtual processors. s390 has a
> > similar feature and should be affected as well.
>=20
> Ahh, so that's triggering it :-), just curious, how often does the HV do
> that to you?=20

OK, so Ben told me on IRC this can happen quite frequently, to which I
must ask WTF were you guys smoking? Flipping the CPU topology every time
the HV scheduler does something funny is quite insane. And you did that
without ever talking to the scheduler folks, not cool.

That is of course aside from the fact that we have a real bug there that
needs fixing, but really guys, WTF!

  reply	other threads:[~2011-03-09 11:34 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-09  2:58 [BUG] rebuild_sched_domains considered dangerous Benjamin Herrenschmidt
2011-03-09 10:19 ` Peter Zijlstra
2011-03-09 11:33   ` Peter Zijlstra [this message]
2011-03-09 13:15     ` Martin Schwidefsky
2011-03-09 13:19       ` Peter Zijlstra
2011-03-09 13:31         ` Martin Schwidefsky
2011-03-09 13:33           ` Peter Zijlstra
2011-03-09 13:46             ` Martin Schwidefsky
2011-03-09 13:54               ` Peter Zijlstra
2011-03-09 15:26     ` Steven Rostedt
2011-03-09 13:01   ` Peter Zijlstra
2011-03-10 14:10     ` Peter Zijlstra
2011-04-20 10:07       ` Peter Zijlstra
2011-04-20 22:01         ` Benjamin Herrenschmidt
2011-05-09 21:26           ` Jesse Larrew
2011-05-10 14:09             ` Peter Zijlstra
2011-05-11 16:17               ` Jesse Larrew
2011-06-03 14:47                 ` Peter Zijlstra

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1299670429.2308.2834.camel@twins \
    --to=peterz@infradead.org \
    --cc=benh@kernel.crashing.org \
    --cc=jlarrew@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=schwidefsky@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).