* [PATCH] powerpc/pseries: Disable VPNH feature
@ 2011-03-09 23:00 Benjamin Herrenschmidt
2011-03-09 23:07 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2011-03-09 23:00 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Jesse Larrew
This feature triggers nasty races in the scheduler between the
rebuilding of the topology and the load balancing code, causing
the machine to hang.
Disable it for now until the races are fixed.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Jesse: I'm sending that to Linus now. We'll sort things out for the
next release.
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index fd48123..74f1baa 100644
--- a/arch/powerpc/mm/numa.c
+++ b/arch/powerpc/mm/numa.c
@@ -1516,6 +1516,7 @@ int start_topology_update(void)
{
int rc = 0;
+#if 0 /* Disabled until races with load balancing are fixed */
if (firmware_has_feature(FW_FEATURE_VPHN) &&
get_lppaca()->shared_proc) {
vphn_enabled = 1;
@@ -1524,6 +1525,7 @@ int start_topology_update(void)
set_topology_timer();
rc = 1;
}
+#endif
return rc;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] powerpc/pseries: Disable VPNH feature
2011-03-09 23:00 [PATCH] powerpc/pseries: Disable VPNH feature Benjamin Herrenschmidt
@ 2011-03-09 23:07 ` Benjamin Herrenschmidt
0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2011-03-09 23:07 UTC (permalink / raw)
To: linuxppc-dev; +Cc: Jesse Larrew
On Thu, 2011-03-10 at 10:00 +1100, Benjamin Herrenschmidt wrote:
> This feature triggers nasty races in the scheduler between the
> rebuilding of the topology and the load balancing code, causing
> the machine to hang.
>
> Disable it for now until the races are fixed.
>
> Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> ---
>
> Jesse: I'm sending that to Linus now. We'll sort things out for the
> next release.
>
> diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
> index fd48123..74f1baa 100644
> --- a/arch/powerpc/mm/numa.c
> +++ b/arch/powerpc/mm/numa.c
> @@ -1516,6 +1516,7 @@ int start_topology_update(void)
> {
> int rc = 0;
>
> +#if 0 /* Disabled until races with load balancing are fixed */
> if (firmware_has_feature(FW_FEATURE_VPHN) &&
> get_lppaca()->shared_proc) {
> vphn_enabled = 1;
> @@ -1524,6 +1525,7 @@ int start_topology_update(void)
> set_topology_timer();
> rc = 1;
> }
> +#endif
Turning that into if (0 && instead to avoid compiler warnings
and thus build failures
Cheers,
Ben.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-03-09 23:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-09 23:00 [PATCH] powerpc/pseries: Disable VPNH feature Benjamin Herrenschmidt
2011-03-09 23:07 ` Benjamin Herrenschmidt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).