From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: Linuxppc-dev list <linuxppc-dev@ozlabs.org>,
devicetree-discuss <devicetree-discuss@lists.ozlabs.org>,
Prabhakar Kushwaha <prabhakar@freescale.com>
Subject: Re: checking status semantics with compatible functions
Date: Tue, 05 Apr 2011 21:59:36 +1000 [thread overview]
Message-ID: <1302004776.2549.153.camel@pasglop> (raw)
In-Reply-To: <20110330143113.GA13685@ponder.secretlab.ca>
On Wed, 2011-03-30 at 08:31 -0600, Grant Likely wrote:
> Yes, of_device_is_available() should be checked, but it should not be
> added directly to of_device_is_compatible(). I'm okay with adding
> a helper variant that does the of_device_is_compatible() check.
>
> In that particular case, I'd also suggest using
> for_each_matching_node().
Agreed. A device might be unavailable due to how FW configured the
machine, but made later on available by the kernel, that shouldn't
impact the interface compatibility test.
Cheers,
Ben.
prev parent reply other threads:[~2011-04-05 11:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <9BC4C90E-090F-4961-A242-10D769C08738@kernel.crashing.org>
2011-03-30 8:26 ` checking status semantics with compatible functions Kumar Gala
2011-03-30 14:31 ` Grant Likely
2011-04-05 11:59 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302004776.2549.153.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=prabhakar@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).