From: Ayman El-Khashab <ayman@elkhashab.com>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org
Cc: Ayman El-Khashab <ayman@elkhashab.com>
Subject: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX
Date: Fri, 8 Apr 2011 13:22:09 -0500 [thread overview]
Message-ID: <1302286930-9988-1-git-send-email-ayman@elkhashab.com> (raw)
From: Ayman El-Khashab <ayman@elkhashab.com>
This patch is to fix the PCIe on the 460SX CPU. As far as I can tell,
the 460SX must be using a different core than the previous 4xx SOCs.
The registers aren't the same and it appears DCRs that existed on
previous parts don't exist on this one. Perhaps somebody from AMCC
can chime in. In any case, the main problem was that the TX and RX
weren't enabled so nothing downstream from the RP was ever found.
And the check to set "port->link" would never work (as far as I could
tell). I could not find any DCRs in this part to indicate when the
link was up and there isn't an obvious loopback, so the following
call would fail and result in no devices found.
ppc4xx_pciex_wait_on_sdr(port, PESDRn_LOOP, 1 << 28, 1 << 28, 100)
It would be better to detect the link status, but I don't see an
obvious way to do that from the data sheet. U-boot just skips the
link check as well for this part.
Ayman El-Khashab (1):
ppc4xx: Fix PCIe scanning for the 460SX
arch/powerpc/sysdev/ppc4xx_pci.c | 35 +++++++++++++++++++++++++++++++----
1 files changed, 31 insertions(+), 4 deletions(-)
--
1.7.4.3
next reply other threads:[~2011-04-08 18:34 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 18:22 Ayman El-Khashab [this message]
2011-04-08 18:22 ` [PATCH 1/1] ppc4xx: Fix PCIe scanning for the 460SX Ayman El-Khashab
2011-04-08 23:48 ` [PATCH 0/1] " Benjamin Herrenschmidt
2011-04-13 2:09 ` Tirumala Marri
2011-04-29 17:02 ` Ayman El-Khashab
2011-04-29 20:37 ` Benjamin Herrenschmidt
2011-05-01 4:28 ` Tirumala Marri
2011-05-04 5:32 ` Benjamin Herrenschmidt
2011-05-05 16:44 ` Tirumala Marri
2011-05-09 16:09 ` Ayman El-Khashab
2011-05-12 18:16 ` Tirumala Marri
2011-05-24 3:40 ` Benjamin Herrenschmidt
2011-05-27 16:51 ` Ayman El-Khashab
2011-05-27 22:57 ` Benjamin Herrenschmidt
2011-05-31 21:27 ` Tirumala Marri
2011-06-27 10:14 ` Ayman El-Khashab
2011-06-27 10:15 ` Benjamin Herrenschmidt
2011-05-31 21:18 ` Tirumala Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1302286930-9988-1-git-send-email-ayman@elkhashab.com \
--to=ayman@elkhashab.com \
--cc=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).