* [PATCH] driver/e1000e: Fix default interrupt mode select
@ 2011-04-12 4:56 Prabhakar Kushwaha
2011-04-12 21:27 ` David Miller
2011-04-12 21:32 ` [E1000-devel] " Jeff Kirsher
0 siblings, 2 replies; 6+ messages in thread
From: Prabhakar Kushwaha @ 2011-04-12 4:56 UTC (permalink / raw)
To: linuxppc-dev, linux.nics, auke-jan.h.kok, e1000-devel, netdev
Cc: meet2prabhu, Prabhakar, Jin Qing
From: Prabhakar <prabhakar@freescale.com>
The Intel e1000 device driver defaults to MSI interrupt mode, even if MSI
support is not enabled
Signed-off-by: Jin Qing <b24347@freescale.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
Based upon git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git(branch master)
added netdev mail-list and e1000 mail-list & maintainer
drivers/net/e1000e/param.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e1000e/param.c b/drivers/net/e1000e/param.c
index a150e48..7b3bbec 100644
--- a/drivers/net/e1000e/param.c
+++ b/drivers/net/e1000e/param.c
@@ -390,7 +390,11 @@ void __devinit e1000e_check_options(struct e1000_adapter *adapter)
.type = range_option,
.name = "Interrupt Mode",
.err = "defaulting to 2 (MSI-X)",
+#ifdef CONFIG_PCI_MSI
.def = E1000E_INT_MODE_MSIX,
+#else
+ .def = E1000E_INT_MODE_LEGACY,
+#endif
.arg = { .r = { .min = MIN_INTMODE,
.max = MAX_INTMODE } }
};
--
1.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] driver/e1000e: Fix default interrupt mode select
2011-04-12 4:56 [PATCH] driver/e1000e: Fix default interrupt mode select Prabhakar Kushwaha
@ 2011-04-12 21:27 ` David Miller
2011-04-12 21:31 ` Jeff Kirsher
2011-04-12 21:32 ` [E1000-devel] " Jeff Kirsher
1 sibling, 1 reply; 6+ messages in thread
From: David Miller @ 2011-04-12 21:27 UTC (permalink / raw)
To: prabhakar
Cc: meet2prabhu, auke-jan.h.kok, linux.nics, b24347, e1000-devel,
netdev, jeffrey.t.kirsher, linuxppc-dev
From: Prabhakar Kushwaha <prabhakar@freescale.com>
Date: Tue, 12 Apr 2011 10:26:03 +0530
> From: Prabhakar <prabhakar@freescale.com>
>
> The Intel e1000 device driver defaults to MSI interrupt mode, even if MSI
> support is not enabled
>
> Signed-off-by: Jin Qing <b24347@freescale.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
> Based upon git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git(branch master)
>
> added netdev mail-list and e1000 mail-list & maintainer
Intel folks, you got this?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] driver/e1000e: Fix default interrupt mode select
2011-04-12 21:27 ` David Miller
@ 2011-04-12 21:31 ` Jeff Kirsher
0 siblings, 0 replies; 6+ messages in thread
From: Jeff Kirsher @ 2011-04-12 21:31 UTC (permalink / raw)
To: David Miller
Cc: meet2prabhu@gmail.com, Kok, Auke-jan H, b24347@freescale.com,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, prabhakar@freescale.com,
Linux NICS
[-- Attachment #1: Type: text/plain, Size: 673 bytes --]
On Tue, 2011-04-12 at 14:27 -0700, David Miller wrote:
> From: Prabhakar Kushwaha <prabhakar@freescale.com>
> Date: Tue, 12 Apr 2011 10:26:03 +0530
>
> > From: Prabhakar <prabhakar@freescale.com>
> >
> > The Intel e1000 device driver defaults to MSI interrupt mode, even if MSI
> > support is not enabled
> >
> > Signed-off-by: Jin Qing <b24347@freescale.com>
> > Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> > ---
> > Based upon git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git(branch master)
> >
> > added netdev mail-list and e1000 mail-list & maintainer
>
> Intel folks, you got this?
Yes. Thanks Dave.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [E1000-devel] [PATCH] driver/e1000e: Fix default interrupt mode select
2011-04-12 4:56 [PATCH] driver/e1000e: Fix default interrupt mode select Prabhakar Kushwaha
2011-04-12 21:27 ` David Miller
@ 2011-04-12 21:32 ` Jeff Kirsher
1 sibling, 0 replies; 6+ messages in thread
From: Jeff Kirsher @ 2011-04-12 21:32 UTC (permalink / raw)
To: Prabhakar Kushwaha
Cc: meet2prabhu@gmail.com, Kok, Auke-jan H, Jin Qing,
e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, Linux NICS
[-- Attachment #1: Type: text/plain, Size: 681 bytes --]
On Mon, 2011-04-11 at 21:56 -0700, Prabhakar Kushwaha wrote:
> From: Prabhakar <prabhakar@freescale.com>
>
> The Intel e1000 device driver defaults to MSI interrupt mode, even if
> MSI
> support is not enabled
>
> Signed-off-by: Jin Qing <b24347@freescale.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
> Based upon
> git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git(branch master)
>
> added netdev mail-list and e1000 mail-list & maintainer
>
> drivers/net/e1000e/param.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
Thanks for the patch, I have added it to my queue of e1000e patches.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] driver/e1000e: Fix default interrupt mode select
@ 2011-04-11 6:38 Prabhakar Kushwaha
2011-04-11 13:11 ` Kumar Gala
0 siblings, 1 reply; 6+ messages in thread
From: Prabhakar Kushwaha @ 2011-04-11 6:38 UTC (permalink / raw)
To: linuxppc-dev; +Cc: meet2prabhu, Prabhakar, Jin Qing
From: Prabhakar <prabhakar@freescale.com>
e1000 default interrupt mode is MSI. No matter user select MSI or
disable MSI in kernel config.
Signed-off-by: Jin Qing <b24347@freescale.com>
Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
---
Based upon git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git(branch master)
drivers/net/e1000e/param.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/net/e1000e/param.c b/drivers/net/e1000e/param.c
index a150e48..7b3bbec 100644
--- a/drivers/net/e1000e/param.c
+++ b/drivers/net/e1000e/param.c
@@ -390,7 +390,11 @@ void __devinit e1000e_check_options(struct e1000_adapter *adapter)
.type = range_option,
.name = "Interrupt Mode",
.err = "defaulting to 2 (MSI-X)",
+#ifdef CONFIG_PCI_MSI
.def = E1000E_INT_MODE_MSIX,
+#else
+ .def = E1000E_INT_MODE_LEGACY,
+#endif
.arg = { .r = { .min = MIN_INTMODE,
.max = MAX_INTMODE } }
};
--
1.7.3
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] driver/e1000e: Fix default interrupt mode select
2011-04-11 6:38 Prabhakar Kushwaha
@ 2011-04-11 13:11 ` Kumar Gala
0 siblings, 0 replies; 6+ messages in thread
From: Kumar Gala @ 2011-04-11 13:11 UTC (permalink / raw)
To: Prabhakar Kushwaha; +Cc: meet2prabhu, linuxppc-dev, Jin Qing
On Apr 11, 2011, at 1:38 AM, Prabhakar Kushwaha wrote:
> From: Prabhakar <prabhakar@freescale.com>
>=20
> e1000 default interrupt mode is MSI. No matter user select MSI or
> disable MSI in kernel config.
>=20
> Signed-off-by: Jin Qing <b24347@freescale.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
> ---
> Based upon =
git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux-2.6.git(branc=
h master)
>=20
> drivers/net/e1000e/param.c | 4 ++++
> 1 files changed, 4 insertions(+), 0 deletions(-)
You should send this to netdev and CC the e1000e Maintainer.
- k=
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-04-12 21:42 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-04-12 4:56 [PATCH] driver/e1000e: Fix default interrupt mode select Prabhakar Kushwaha
2011-04-12 21:27 ` David Miller
2011-04-12 21:31 ` Jeff Kirsher
2011-04-12 21:32 ` [E1000-devel] " Jeff Kirsher
-- strict thread matches above, loose matches on Subject: below --
2011-04-11 6:38 Prabhakar Kushwaha
2011-04-11 13:11 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).