[PATCH 0/1] ppc64: fix build error when compiling with gcc-4.6.0

[PATCH 0/1] ppc64: fix build error when compiling with gcc-4.6.0

[Stratos Psomadakis]

The build error was reported at the Gentoo Bugzilla [1].

When compiling with gcc-4.6.0, a build error occurs: 
"variable ‘old’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors"

This patch removes the unnecessary assignments to the variable, which cause
the compiler warning (used but not set), and build failure, and removes it
completely.

I think it's ok to do that, since the variable wasn't actually used anywhere
inside those two functions that caused the warning. Right?

[1] https://bugs.gentoo.org/show_bug.cgi?id=363935

[PATCH 1/1] ppc64: fix build error when compiling with gcc-4.6.0

[Stratos Psomadakis]

variable 'old' is set but not used, which results to a warning
(-Werror=unused-but-set-variable) when compiling with gcc-4.6.0, and subsequent
build failure.
Remove the variable 'old', since it's not used anyway.

---
 arch/powerpc/include/asm/pgtable-ppc64.h |   13 ++++++-------
 1 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/arch/powerpc/include/asm/pgtable-ppc64.h b/arch/powerpc/include/asm/pgtable-ppc64.h
index 2b09cd5..a49d592 100644
--- a/arch/powerpc/include/asm/pgtable-ppc64.h
+++ b/arch/powerpc/include/asm/pgtable-ppc64.h
@@ -257,21 +257,20 @@ static inline int __ptep_test_and_clear_young(struct mm_struct *mm,
 static inline void ptep_set_wrprotect(struct mm_struct *mm, unsigned long addr,
 				      pte_t *ptep)
 {
-	unsigned long old;
 
-       	if ((pte_val(*ptep) & _PAGE_RW) == 0)
-       		return;
-	old = pte_update(mm, addr, ptep, _PAGE_RW, 0);
+	if ((pte_val(*ptep) & _PAGE_RW) == 0)
+  		return;
+
+	pte_update(mm, addr, ptep, _PAGE_RW, 0);
 }
 
 static inline void huge_ptep_set_wrprotect(struct mm_struct *mm,
 					   unsigned long addr, pte_t *ptep)
 {
-	unsigned long old;
-
 	if ((pte_val(*ptep) & _PAGE_RW) == 0)
 		return;
-	old = pte_update(mm, addr, ptep, _PAGE_RW, 1);
+
+	pte_update(mm, addr, ptep, _PAGE_RW, 1);
 }
 
 /*
-- 
1.7.4.1

Re: [PATCH 1/1] ppc64: fix build error when compiling with gcc-4.6.0

[Stratos Psomadakis]

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

On 18/04/2011 07:38 μμ, Stratos Psomadakis wrote:
> variable 'old' is set but not used, which results to a warning
> (-Werror=unused-but-set-variable) when compiling with gcc-4.6.0, and subsequent
> build failure.
> Remove the variable 'old', since it's not used anyway.
Something went wrong with git-send-email :/

So I send the first mail in the chain as a reply:

The build error was reported at the Gentoo Bugzilla [1].

When compiling with gcc-4.6.0, a build error occurs: 
"variable ‘old’ set but not used [-Werror=unused-but-set-variable]
cc1: all warnings being treated as errors"

This patch removes the unnecessary assignments to the variable 'old', which cause
the compiler warning (used but not set), and build failure, and remove the variable completely.
I think it's ok to do that, since the variable is actually never used. Right?
(of course disabling CONFIG_PPC_WERROR would resolve the build failure, but cleaning up the code a bit, is better I think).

[1] https://bugs.gentoo.org/show_bug.cgi?id=363935

-- 
Stratos Psomadakis
<psomas@ece.ntua.gr>



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]

Re: [PATCH 1/1] ppc64: fix build error when compiling with gcc-4.6.0

[Stratos Psomadakis]

Signed-off-by: Stratos Psomadakis <psomas@cslab.ece.ntua.gr>

-- 
Stratos Psomadakis
<psomas@ece.ntua.gr>