From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: linuxppc-dev@ozlabs.org
Cc: tsenglin@us.ibm.com
Subject: Re: [PATCH 0/2] powerpc/pseries: Reworked support for IO event interrupts
Date: Wed, 04 May 2011 14:31:05 +1000 [thread overview]
Message-ID: <1304483465.2513.338.camel@pasglop> (raw)
In-Reply-To: <1304483324-11155-1-git-send-email-benh@kernel.crashing.org>
On Wed, 2011-05-04 at 14:28 +1000, Benjamin Herrenschmidt wrote:
> Hi Frank !
>
> There were several issues with your patch. Some were nasty bugs such
> as kmalloc(...GFP_KERNEL) at interrupt time, or taking the rtas buffer
> lock from an interrupt, others simply the code being ugly.
>
> I've removed the "generic" event log parsing as it's not useful at
> this point and simplified the code significantly.
>
> Please test and let me know if it works for you before I commit.
FYI. This isn't even compile tested (oops... my bad). It shows you want
I want, feel free to tweak a bit if needed and hopefully we should have
something mergeable.
Also, get rid of your habit of naming pointers something_p, I find it
annoying and waste time removing the _p's
Cheers,
Ben.
prev parent reply other threads:[~2011-05-04 4:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-04 4:28 [PATCH 0/2] powerpc/pseries: Reworked support for IO event interrupts Benjamin Herrenschmidt
2011-05-04 4:28 ` [PATCH 1/2] powerpc/pseries: Add RTAS event log v6 definition Benjamin Herrenschmidt
2011-05-04 4:28 ` [PATCH 2/2] powerpc/pseries: Add support for IO event interrupts Benjamin Herrenschmidt
2011-05-04 4:31 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304483465.2513.338.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tsenglin@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).