From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ayman El-Khashab <ayman@elkhashab.com>
Cc: Tirumala Marri <tmarri@apm.com>,
linuxppc-dev@lists.ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX
Date: Wed, 04 May 2011 15:32:46 +1000 [thread overview]
Message-ID: <1304487166.2513.351.camel@pasglop> (raw)
In-Reply-To: <1304109476.2513.243.camel@pasglop>
On Sat, 2011-04-30 at 06:37 +1000, Benjamin Herrenschmidt wrote:
> On Fri, 2011-04-29 at 12:02 -0500, Ayman El-Khashab wrote:
> > On Tue, Apr 12, 2011 at 07:09:49PM -0700, Tirumala Marri wrote:
> > > You originally submitted the support for 460ex. Can you chime in (and
> > > review Ayman patch) please ?
> > >
> > > [Marri] Ben sure I will review it and send you my feedback in couple of
> > > days.
> >
> > Is there any update on this patch? Any comment? Any reason it _cant_
> > be included?
>
> I'm tempted to put it in if Tirumala doesn't get to review it asap.
Ok so after a closer review, the patch can't go in as-is.
The code in there is meant to work on any 44x with runtime detection of
the type of PCIe bridge.
Your patch uses #ifdef's which breaks this.
Please use the "compatible" property in the device-tree to identify the
460SX specific implementation (of_device_is_compatible(...)) and use
that to trigger your changes.
Also, the patch removes the code for waiting for the link to be up with
a comment "What DCR has the link status on the 460SX?". Please fix that
(Tirumala, can you provide the missing information ?)
Cheers,
Ben.
next prev parent reply other threads:[~2011-05-04 5:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-04-08 18:22 [PATCH 0/1] ppc4xx: Fix PCIe scanning for the 460SX Ayman El-Khashab
2011-04-08 18:22 ` [PATCH 1/1] " Ayman El-Khashab
2011-04-08 23:48 ` [PATCH 0/1] " Benjamin Herrenschmidt
2011-04-13 2:09 ` Tirumala Marri
2011-04-29 17:02 ` Ayman El-Khashab
2011-04-29 20:37 ` Benjamin Herrenschmidt
2011-05-01 4:28 ` Tirumala Marri
2011-05-04 5:32 ` Benjamin Herrenschmidt [this message]
2011-05-05 16:44 ` Tirumala Marri
2011-05-09 16:09 ` Ayman El-Khashab
2011-05-12 18:16 ` Tirumala Marri
2011-05-24 3:40 ` Benjamin Herrenschmidt
2011-05-27 16:51 ` Ayman El-Khashab
2011-05-27 22:57 ` Benjamin Herrenschmidt
2011-05-31 21:27 ` Tirumala Marri
2011-06-27 10:14 ` Ayman El-Khashab
2011-06-27 10:15 ` Benjamin Herrenschmidt
2011-05-31 21:18 ` Tirumala Marri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304487166.2513.351.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=ayman@elkhashab.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=paulus@samba.org \
--cc=tmarri@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).