From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@linux.vnet.ibm.com>
Cc: linuxppc-dev@ozlabs.org, linuxppc-dev <eftakhar.chowdhury@yahoo.com>
Subject: Re: Read/write BCSR registers of PPC460EX
Date: Wed, 04 May 2011 15:37:00 +1000 [thread overview]
Message-ID: <1304487420.2513.352.camel@pasglop> (raw)
In-Reply-To: <20110502124039.GB3269@zod.rchland.ibm.com>
On Mon, 2011-05-02 at 08:40 -0400, Josh Boyer wrote:
> Aside from minor things like using unsigned int instead of unsigned
> long, the code looks correct. The thing to check is if you are
> ioremapping the right physical address, and making sure you're reading
> a
> proper location.
Which is why he should obtain the location from the device-tree rather
than hard coding it !
Cheers,
Ben.
prev parent reply other threads:[~2011-05-04 5:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 11:50 Read/write BCSR registers of PPC460EX linuxppc-dev
2011-05-02 12:40 ` Josh Boyer
2011-05-02 12:53 ` Stefan Roese
2011-05-02 13:36 ` linuxppc-dev
2011-05-02 13:42 ` Stefan Roese
2011-05-04 5:37 ` Benjamin Herrenschmidt
2011-05-04 5:37 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1304487420.2513.352.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=eftakhar.chowdhury@yahoo.com \
--cc=jwboyer@linux.vnet.ibm.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).