From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Milton Miller <miltonm@bga.com>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: powerpc: Make early memory scan more resilient to out of order nodes
Date: Thu, 12 May 2011 21:08:18 +1000 [thread overview]
Message-ID: <1305198498.29820.96.camel@pasglop> (raw)
In-Reply-To: <benh-inital-memory@mdm.bga.com>
On Thu, 2011-05-12 at 03:09 -0500, Milton Miller wrote:
> On Wed, 11 May 2011 about 20:58:18 -0000, Benjamin Herrenschmidt wrote:
> > We keep track of the size of the lowest block of memory and call
> > setup_initial_memory_limit() only after we've parsed them all
> >
>
> Good, we lose our sensitivity to device node ordering.
Yup, A platform we'll release soon has all of them backward :-)
> > diff --git a/arch/powerpc/kernel/prom.c b/arch/powerpc/kernel/prom.c
>
> > index 584b398..27475c6 100644
> > --- a/arch/powerpc/kernel/prom.c
> > +++ b/arch/powerpc/kernel/prom.c
> > @@ -70,6 +70,7 @@ int __initdata iommu_force_on;
> > unsigned long tce_alloc_start, tce_alloc_end;
> > u64 ppc64_rma_size;
> > #endif
> > +static phys_addr_t first_memblock_size;
>
> __initdata
>
> (its only referenced by 2 __init functions)
>
> Acked-by: Milton Miller <miltonm@bga.com>
Ag good, I'll fold that in, thanks.
Cheers,
Ben.
>
> > static int __init early_parse_mem(char *p)
> > {
> ..
> > @@ -507,11 +508,14 @@ void __init early_init_dt_add_memory_arch(u64 base, u64 size)
> ..
> > @@ -708,6 +712,7 @@ void __init early_init_devtree(void *params)
prev parent reply other threads:[~2011-05-12 11:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-12 6:58 [PATCH] powerpc: Make early memory scan more resilient to out of order nodes Benjamin Herrenschmidt
2011-05-12 8:09 ` Milton Miller
2011-05-12 11:08 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1305198498.29820.96.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=miltonm@bga.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).