From: Shawn Guo <shawn.guo@linaro.org>
To: <linux-mmc@vger.kernel.org>
Cc: Shawn Guo <shawn.guo@linaro.org>,
sameo@linux.intel.com, Arnd Bergmann <arnd@arndb.de>,
patches@linaro.org, devicetree-discuss@lists.ozlabs.org,
Saeed Bishara <saeed@marvell.com>,
Xiaobo Xie <X.Xie@freescale.com>,
kernel@pengutronix.de, Mike Rapoport <mike@compulab.co.il>,
Olof Johansson <olof@lixom.net>, Chris Ball <cjb@laptop.org>,
linuxppc-dev@lists.ozlabs.org,
Albert Herranz <albert_herranz@yahoo.es>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 4/4] mmc: sdhci: merge two sdhci-pltfm.h into one
Date: Wed, 25 May 2011 19:01:54 +0800 [thread overview]
Message-ID: <1306321314-2493-5-git-send-email-shawn.guo@linaro.org> (raw)
In-Reply-To: <1306321314-2493-1-git-send-email-shawn.guo@linaro.org>
The structure sdhci_pltfm_data is not necessarily to be in a public
header like include/linux/mmc/sdhci-pltfm.h, so the patch moves it
into drivers/mmc/host/sdhci-pltfm.h and eliminates the former one.
Signed-off-by: Shawn Guo <shawn.guo@linaro.org>
Reviewed-by: Grant Likely <grant.likely@secretlab.ca>
Reviewed-by: Wolfram Sang <w.sang@pengutronix.de>
---
drivers/mmc/host/sdhci-cns3xxx.c | 1 -
drivers/mmc/host/sdhci-esdhc-imx.c | 1 -
drivers/mmc/host/sdhci-pltfm.h | 6 +++++-
include/linux/mmc/sdhci-pltfm.h | 29 -----------------------------
4 files changed, 5 insertions(+), 32 deletions(-)
delete mode 100644 include/linux/mmc/sdhci-pltfm.h
diff --git a/drivers/mmc/host/sdhci-cns3xxx.c b/drivers/mmc/host/sdhci-cns3xxx.c
index ac4b26f..025d1a5 100644
--- a/drivers/mmc/host/sdhci-cns3xxx.c
+++ b/drivers/mmc/host/sdhci-cns3xxx.c
@@ -15,7 +15,6 @@
#include <linux/delay.h>
#include <linux/device.h>
#include <linux/mmc/host.h>
-#include <linux/mmc/sdhci-pltfm.h>
#include <mach/cns3xxx.h>
#include "sdhci.h"
#include "sdhci-pltfm.h"
diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c
index e27ccbb..977f142 100644
--- a/drivers/mmc/host/sdhci-esdhc-imx.c
+++ b/drivers/mmc/host/sdhci-esdhc-imx.c
@@ -18,7 +18,6 @@
#include <linux/gpio.h>
#include <linux/slab.h>
#include <linux/mmc/host.h>
-#include <linux/mmc/sdhci-pltfm.h>
#include <linux/mmc/mmc.h>
#include <linux/mmc/sdio.h>
#include <mach/hardware.h>
diff --git a/drivers/mmc/host/sdhci-pltfm.h b/drivers/mmc/host/sdhci-pltfm.h
index fe27b83..fd72694 100644
--- a/drivers/mmc/host/sdhci-pltfm.h
+++ b/drivers/mmc/host/sdhci-pltfm.h
@@ -14,9 +14,13 @@
#include <linux/clk.h>
#include <linux/types.h>
#include <linux/platform_device.h>
-#include <linux/mmc/sdhci-pltfm.h>
#include <linux/mmc/sdhci.h>
+struct sdhci_pltfm_data {
+ struct sdhci_ops *ops;
+ unsigned int quirks;
+};
+
struct sdhci_pltfm_host {
struct clk *clk;
void *priv; /* to handle quirks across io-accessor calls */
diff --git a/include/linux/mmc/sdhci-pltfm.h b/include/linux/mmc/sdhci-pltfm.h
deleted file mode 100644
index f1c2ac3..0000000
--- a/include/linux/mmc/sdhci-pltfm.h
+++ /dev/null
@@ -1,29 +0,0 @@
-/*
- * Platform data declarations for the sdhci-pltfm driver.
- *
- * Copyright (c) 2010 MontaVista Software, LLC.
- *
- * Author: Anton Vorontsov <avorontsov@ru.mvista.com>
- *
- * This program is free software; you can redistribute it and/or modify
- * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or (at
- * your option) any later version.
- */
-
-#ifndef _SDHCI_PLTFM_H
-#define _SDHCI_PLTFM_H
-
-struct sdhci_ops;
-
-/**
- * struct sdhci_pltfm_data - SDHCI platform-specific information & hooks
- * @ops: optional pointer to the platform-provided SDHCI ops
- * @quirks: optional SDHCI quirks
- */
-struct sdhci_pltfm_data {
- struct sdhci_ops *ops;
- unsigned int quirks;
-};
-
-#endif /* _SDHCI_PLTFM_H */
--
1.7.4.1
next prev parent reply other threads:[~2011-05-25 11:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-25 11:01 [PATCH v3 0/4] Consolidate sdhci pltfm & OF drivers and get them self registered Shawn Guo
2011-05-25 11:01 ` [PATCH v3 1/4] mmc: sdhci: make sdhci-pltfm device drivers " Shawn Guo
2011-05-25 11:01 ` [PATCH v3 2/4] mmc: sdhci: eliminate sdhci_of_host and sdhci_of_data Shawn Guo
2011-05-25 11:01 ` [PATCH v3 3/4] mmc: sdhci: make sdhci-of device drivers self registered Shawn Guo
2011-05-25 11:01 ` Shawn Guo [this message]
2011-05-27 7:26 ` [PATCH v3 0/4] Consolidate sdhci pltfm & OF drivers and get them " Grant Likely
2011-05-27 8:06 ` Wolfram Sang
2011-05-27 9:07 ` Shawn Guo
2011-05-27 16:06 ` Chris Ball
2011-05-27 20:29 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1306321314-2493-5-git-send-email-shawn.guo@linaro.org \
--to=shawn.guo@linaro.org \
--cc=X.Xie@freescale.com \
--cc=albert_herranz@yahoo.es \
--cc=arnd@arndb.de \
--cc=cjb@laptop.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mmc@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mike@compulab.co.il \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=saeed@marvell.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).