From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Cédric Cano" <ccano@interfaceconcept.com>
Cc: linuxppc-dev@lists.ozlabs.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH 1/1] Big endian swap for Marvell 6440 SAS driver
Date: Tue, 14 Jun 2011 17:05:23 +1000 [thread overview]
Message-ID: <1308035123.2874.1055.camel@pasglop> (raw)
In-Reply-To: <4DF702F3.704@interfaceconcept.com>
On Tue, 2011-06-14 at 08:42 +0200, Cédric Cano wrote:
> Hi Ben,
>
> You're alright! I hadn't thought to use le32_to_cpu.
> Do you want I make a new patch?
Well, I'm not the maintainer of the subsystem or of the driver, so I'm
not going to be the one accepting/merging it :-)
I'm just reviewing the patch, but yes, I think you should, and you
should send it to the right people, ie, I think at least linux-scsi and
possibly the author/maintainer of the driver itself.
Cheers,
Ben.
> Cedric
>
> Le 12/06/2011 00:45, Benjamin Herrenschmidt a écrit :
> > On Fri, 2011-06-10 at 15:56 +0200, Cédric Cano wrote:
> >> Hi,
> >>
> >> Marvell SAS driver doesn't work on powerpc architecture due to big
> >> endian swap. I've tested it with the MV6440 chip.
> >> Here you can find the patch for Linux 2.6.39.1.
> >>
> >> Cedric Cano
> >>
> >> Signed-off-by: Cedric Cano<ccano@interfaceconcept.com>
> >> ---
> >> --- drivers/scsi/mvsas/mv_sas.c 2011-06-10 15:50:04.000000000 +0200
> >> +++ drivers/scsi/mvsas/mv_sas.c 2011-06-10 15:50:12.000000000 +0200
> >> @@ -1143,6 +1143,14 @@
> >> MVS_CHIP_DISP->write_port_cfg_addr(mvi, i, PHYR_SATA_SIG0);
> >> s[0] = MVS_CHIP_DISP->read_port_cfg_data(mvi, i);
> >>
> >> + /* swap for big endian devices because of use of these data in bytes */
> >> +#ifdef __BIG_ENDIAN
> >> + s[0] = swab32(s[0]);
> >> + s[1] = swab32(s[1]);
> >> + s[2] = swab32(s[2]);
> >> + s[3] = swab32(s[3]);
> >> +#endif /* __BIG_ENDIAN */
> > Hi Cedric !
> >
> > Thanks for this. CC'ing linux-scsi.
> >
> > Note that it would probably have been better to use le32_to_cpu, which
> > avoids the ifdef completely.
> >
> > Cheers,
> > Ben.
> >
> >> /* Workaround: take some ATAPI devices for ATA */
> >> if (((s[1]& 0x00FFFFFF) == 0x00EB1401)&& (*(u8 *)&s[3] == 0x01))
> >> s[1] = 0x00EB1401 | (*((u8 *)&s[1] + 3)& 0x10);
> >>
> >> ---
> >> _______________________________________________
> >> Linuxppc-dev mailing list
> >> Linuxppc-dev@lists.ozlabs.org
> >> https://lists.ozlabs.org/listinfo/linuxppc-dev
> >
> >
prev parent reply other threads:[~2011-06-14 7:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-10 13:56 [PATCH 1/1] Big endian swap for Marvell 6440 SAS driver Cédric Cano
2011-06-11 22:45 ` Benjamin Herrenschmidt
2011-06-14 6:42 ` Cédric Cano
2011-06-14 7:05 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308035123.2874.1055.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=ccano@interfaceconcept.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).