From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mprc.pku.edu.cn (mprc.pku.edu.cn [162.105.203.9]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 9AA06B6F7C for ; Wed, 15 Jun 2011 11:33:05 +1000 (EST) Subject: Re: [RFC,PATCH] Cleanup PC parallel port Kconfig From: Guan Xuetao To: Ralf Baechle In-Reply-To: <20110614190850.GA13526@linux-mips.org> References: <20110614190850.GA13526@linux-mips.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 15 Jun 2011 09:24:06 +0800 Message-ID: <1308101046.4727.10.camel@epip-laptop> Mime-Version: 1.0 Cc: linux-mips@linux-mips.org, linux-m68k@vger.kernel.org, linux-ia64@vger.kernel.org, linux-sh@vger.kernel.org, Chen Liqin , Paul Mackerras , "H. Peter Anvin" , sparclinux@vger.kernel.org, Lennox Wu , linux-arch@vger.kernel.org, Jesper Nilsson , Russell King , Yoshinori Sato , Helge Deller , x86@kernel.org, "James E.J. Bottomley" , Ingo Molnar , Geert Uytterhoeven , Matt Turner , Fenghua Yu , microblaze-uclinux@itee.uq.edu.au, Chris Metcalf , Mikael Starvik , Ivan Kokshaysky , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Richard Henderson , Chris Zankel , Michal Simek , Tony Luck , linux-parisc@vger.kernel.org, linux-cris-kernel@axis.com, linux-kernel@vger.kernel.org, Kyle McMartin , Paul Mundt , linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, "David S. Miller" Reply-To: gxt@mprc.pku.edu.cn List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2011-06-14 at 20:08 +0100, Ralf Baechle wrote: > The PC parallel port Kconfig as acquired one of those messy terms to > describe it's architecture dependencies: > > depends on (!SPARC64 || PCI) && !SPARC32 && !M32R && !FRV && \ > (!M68K || ISA) && !MN10300 && !AVR32 && !BLACKFIN > > This isn't just ugly - it also almost certainly describes the dependencies > too coarse grainedly. This is an attempt at cleaing the mess up. > > I tried to faithfully aproximate the old behaviour but the existing > behaviour seems inacurate if not wrong for some architectures or platforms. > To improve on this I rely on comments from other arch and platforms > maintainers. Any system that can take PCI multi-IO card or has a PC-style > parallel port on the mainboard should probably should now do a > select HAVE_PC_PARPORT. And some arch Kconfig files should further > restrict the use of HAVE_PC_PARPORT to only those platforms that actually > need it. > > Thanks, > > Ralf > diff --git a/arch/unicore32/Kconfig b/arch/unicore32/Kconfig > index e57dcce..3832e7e 100644 > --- a/arch/unicore32/Kconfig > +++ b/arch/unicore32/Kconfig > @@ -8,6 +8,7 @@ config UNICORE32 > select HAVE_KERNEL_BZIP2 > select HAVE_KERNEL_LZO > select HAVE_KERNEL_LZMA > + select HAVE_PC_PARPORT > select GENERIC_FIND_FIRST_BIT > select GENERIC_IRQ_PROBE > select GENERIC_IRQ_SHOW In UniCore32, only some debug-boards need to support parport. So I'd like to add HAVE_PC_PARPORT and related configs to certian *_defconfig, but not in Kconfig. Thanks Ralf. Guan Xuetao