From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: deepthi@linux.vnet.ibm.com
Cc: linuxppc-dev@ozlabs.org, linux-pm@lists.linux-foundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] perf_events: Enable idle state tracing for pseries (ppc64)
Date: Fri, 17 Jun 2011 14:24:19 +1000 [thread overview]
Message-ID: <1308284659.32158.4.camel@pasglop> (raw)
In-Reply-To: <20110601123554.GA12492@deepthi.in.ibm.com>
On Wed, 2011-06-01 at 18:05 +0530, Deepthi Dharwar wrote:
> Hi,
>
> Please find below a patch, which has perf_events added for pseries (ppc64)
> platform in order to emit the trace required for perf timechart.
> It essentially enables perf timechart for pseries platfrom to analyse
> power savings events like cpuidle states.
Unless I'm mistaken, you added traces to dedicated CPU idle sleep but
not shared processor. Any reason ?
Also I don't really know that tracing stuff but what's the point of
having start/end _and trace_cpu_idle if you're going to always start &
end around a single occurence of trace_cpu_idle ?
Wouldn't there be a way to start/end and then trace the snooze and
subsequent cede within the same start/end section or that makes no
sense ?
Also would there be any interest in doing the tracing more generically
in idle.c ?
Cheers,
Ben.
next prev parent reply other threads:[~2011-06-17 4:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-01 12:35 [PATCH] perf_events: Enable idle state tracing for pseries (ppc64) Deepthi Dharwar
2011-06-17 4:24 ` Benjamin Herrenschmidt [this message]
2011-06-20 17:18 ` deepthi
2011-06-20 21:42 ` Benjamin Herrenschmidt
2011-06-21 16:29 ` deepthi
2011-06-21 16:40 ` Deepthi Dharwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308284659.32158.4.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=deepthi@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).