linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Matt Mackall <mpm@selenic.com>
To: Kim Phillips <kim.phillips@freescale.com>
Cc: linuxppc-dev@lists.ozlabs.org,
	Herbert Xu <herbert@gondor.apana.org.au>,
	linux-crypto@vger.kernel.org
Subject: Re: [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG
Date: Tue, 21 Jun 2011 13:59:55 -0500	[thread overview]
Message-ID: <1308682795.4954.42.camel@calx> (raw)
In-Reply-To: <20110621113836.fbf14710.kim.phillips@freescale.com>

On Tue, 2011-06-21 at 11:38 -0500, Kim Phillips wrote:
> [adding linux-crypto]
> 
> On Tue, 21 Jun 2011 10:56:02 -0500
> Matt Mackall <mpm@selenic.com> wrote:
> 
> > On Tue, 2011-06-21 at 08:19 -0400, Josh Boyer wrote:
> > > +static struct hwrng ppc4xx_rng = {
> > > +	.name = MODULE_NAME,
> > > +	.data_present = ppc4xx_rng_data_present,
> > > +	.data_read = ppc4xx_rng_data_read,
> > > +};
> 
> under what criteria should new hwrng drivers use the new hwrng API?

If the RNG is not fundamentally u32-based (like this one), it's strongly
encouraged. We'll eventually abandon the old interface, but I don't
think there's any hurry.

-- 
Mathematics is the supreme nostalgia of our time.

  reply	other threads:[~2011-06-21 19:00 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-21 12:19 [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG Josh Boyer
2011-06-21 15:56 ` Matt Mackall
2011-06-21 16:38   ` Kim Phillips
2011-06-21 18:59     ` Matt Mackall [this message]
2011-06-22 11:14   ` Josh Boyer
2011-06-22 11:58     ` Herbert Xu
2011-06-27  7:39   ` Herbert Xu
2011-06-22 14:49 ` Williams, Michael (mwilli60)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1308682795.4954.42.camel@calx \
    --to=mpm@selenic.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=kim.phillips@freescale.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).