From: Ben Hutchings <bhutchings@solarflare.com>
To: Matt Evans <matt@ozlabs.org>
Cc: netdev@vger.kernel.org, linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [RFC PATCH 1/1] BPF JIT for PPC64
Date: Sat, 25 Jun 2011 02:58:34 +0100 [thread overview]
Message-ID: <1308967114.3093.1379.camel@localhost> (raw)
In-Reply-To: <4E04288F.4090201@ozlabs.org>
On Fri, 2011-06-24 at 16:02 +1000, Matt Evans wrote:
[...]
> + case BPF_S_ALU_ADD_K: /* A += K; */
> + if (!K)
> + break;
> + if (K < 32768)
> + PPC_ADDI(r_A, r_A, K);
> + else
> + PPC_ADDI(r_A, r_A, IMM_L(K));
> + PPC_ADDIS(r_A, r_A, IMM_HA(K));
> + break;
Missing braces.
> + case BPF_S_ALU_SUB_X: /* A -= X; */
> + ctx->seen |= SEEN_XREG;
> + PPC_SUB(r_A, r_A, r_X);
> + break;
> + case BPF_S_ALU_SUB_K: /* A -= K */
> + if (!K)
> + break;
> + if (K < 32768)
> + PPC_ADDI(r_A, r_A, -K);
> + else
> + PPC_ADDI(r_A, r_A, IMM_L(-K));
> + PPC_ADDIS(r_A, r_A, IMM_HA(-K));
> + break;
[...]
Here as well.
Ben.
--
Ben Hutchings, Senior Software Engineer, Solarflare
Not speaking for my employer; that's the marketing department's job.
They asked us to note that Solarflare product names are trademarked.
next prev parent reply other threads:[~2011-06-25 2:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-24 6:02 [RFC PATCH 1/1] BPF JIT for PPC64 Matt Evans
2011-06-25 1:58 ` Ben Hutchings [this message]
2011-07-11 6:21 ` Matt Evans
2011-06-25 7:33 ` Andreas Schwab
2011-06-25 7:49 ` Eric Dumazet
2011-07-11 7:04 ` Matt Evans
2011-07-11 6:27 ` Matt Evans
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1308967114.3093.1379.camel@localhost \
--to=bhutchings@solarflare.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=matt@ozlabs.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).