From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ayman El-Khashab <ayman@elkhashab.com>
Cc: linuxppc-dev@ozlabs.org, Rupjyoti Sarmah <rsarmah@amcc.com>,
rsarmah@apm.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4]PPC4xx: Adding PCI(E) MSI support
Date: Wed, 29 Jun 2011 09:15:28 +1000 [thread overview]
Message-ID: <1309302928.32158.470.camel@pasglop> (raw)
In-Reply-To: <20110628223131.GA10267@crust.elkhashab.com>
On Tue, 2011-06-28 at 17:31 -0500, Ayman El-Khashab wrote:
> > > +static int ppc4xx_setup_pcieh_hw(struct platform_device *dev,
> > > + struct resource res, struct
> ppc4xx_msi *msi)
> > > +{
> > > +
>
> <snip>
>
> > > +
> > > + msi->msi_dev = of_find_node_by_name(NULL, "ppc4xx-msi");
> > > + if (msi->msi_dev)
> > > + return -ENODEV;
>
> This does not look correct. I guess it should probably read
>
> if (!msi->msi_dev) .....
Indeed, that looks bogus. Rupjyoti, please test and send fixes if
necessary, obviously this code has not been tested.
This is not part of the bits I fixed up so I looks to me like the
original patch was wrong (and thus obviously untested !!!)
Cheers,
Ben.
next prev parent reply other threads:[~2011-06-28 23:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-30 9:10 [PATCH v4]PPC4xx: Adding PCI(E) MSI support Rupjyoti Sarmah
2011-05-19 12:53 ` Josh Boyer
2011-05-26 5:24 ` Benjamin Herrenschmidt
2011-06-28 22:31 ` Ayman El-Khashab
2011-06-28 23:15 ` Benjamin Herrenschmidt [this message]
2011-06-29 15:22 ` Ayman El-Khashab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309302928.32158.470.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=ayman@elkhashab.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rsarmah@amcc.com \
--cc=rsarmah@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).