From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 2324BB6F5B for ; Sat, 2 Jul 2011 09:15:32 +1000 (EST) Subject: Re: [PATCH 2/2] powerpc/mm: Fix memory_block_size_bytes() for non-pseries From: Benjamin Herrenschmidt To: Ingo Molnar In-Reply-To: <20110701121516.GD28008@elte.hu> References: <1308013071.2874.785.camel@pasglop> <20110701121516.GD28008@elte.hu> Content-Type: text/plain; charset="UTF-8" Date: Sat, 02 Jul 2011 09:15:12 +1000 Message-ID: <1309562112.14501.257.camel@pasglop> Mime-Version: 1.0 Cc: "linux-mm@kvack.org" , Thomas Gleixner , linuxppc-dev , "linux-kernel@vger.kernel.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2011-07-01 at 14:15 +0200, Ingo Molnar wrote: > > +/* WARNING: This is going to override the generic definition whenever > > + * pseries is built-in regardless of what platform is active at boot > > + * time. This is fine for now as this is the only "option" and it > > + * should work everywhere. If not, we'll have to turn this into a > > + * ppc_md. callback > > + */ > > Just a small nit, please use the customary (multi-line) comment > style: > > /* > * Comment ..... > * ...... goes here. > */ > > specified in Documentation/CodingStyle. Ah ! Here goes my sneak attempts at violating coding style while nobody notices :-) No seriously, that sort of stuff shouldn't be such a hard rule... In some cases the "official" way looks nicer, on some cases it's just a waste of space, and I've grown to prefer my slightly more compact form, at least depending on how the surrounding code looks like. Since that's all powerpc arch code, I believe I'm entitled to that little bit of flexibility in how the code looks like :-) It's not like I'm GoingToPlayWithCaps() or switching to 3-char tabs :-) Cheers, Ben.