From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Anton Blanchard <anton@samba.org>
Cc: borntraeger@de.ibm.com, brueckner@linux.vnet.ibm.com,
linuxppc-dev@lists.ozlabs.org
Subject: Re: hvc_console change results in corrupt oops output
Date: Mon, 04 Jul 2011 23:56:27 +1000 [thread overview]
Message-ID: <1309787787.14501.268.camel@pasglop> (raw)
In-Reply-To: <20110704205738.742e56d0@kryten>
On Mon, 2011-07-04 at 20:57 +1000, Anton Blanchard wrote:
.../...
> The hypervisor gives us a busy return, so we could retry a number of
> times instead of dropping it on the floor. We'd need to do it in the
> hvc_console driver - the tty drivers share the same backend
> functions so we can't hide it in the pseries put_chars function.
For kernel console, I don't see why not wait forever ... If the
underlying backend really lost the connection it can always return a
negative error no ?
Or we could have "well defined" return codes for "wait forever" vs.
"drop this" ... maybe return -EAGAIN.
Cheers,
Ben.
next prev parent reply other threads:[~2011-07-04 13:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-04 10:57 hvc_console change results in corrupt oops output Anton Blanchard
2011-07-04 13:56 ` Benjamin Herrenschmidt [this message]
2011-07-04 14:24 ` Hendrik Brueckner
2011-07-05 4:17 ` Tabi Timur-B04825
2011-07-05 6:22 ` Benjamin Herrenschmidt
2011-07-05 13:51 ` Tabi Timur-B04825
2011-07-05 14:28 ` [RFC] [PATCH] hvc_console: improve tty/console put_chars handling Hendrik Brueckner
2011-07-06 7:49 ` Anton Blanchard
2011-07-06 7:50 ` [PATCH 1/2]: " Anton Blanchard
2011-07-06 7:51 ` [PATCH 2/2]: powerpc/pseries/hvconsole: Fix dropped console output Anton Blanchard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309787787.14501.268.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@samba.org \
--cc=borntraeger@de.ibm.com \
--cc=brueckner@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).