From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Richard A Lary <rlary@linux.vnet.ibm.com>
Cc: James Smart <james.smart@emulex.com>,
linux-pci@vger.kernel.org, Anton Blanchard <anton@au1.ibm.com>,
Richard Lary <rlary@us.ibm.com>, Jon Mason <jdmason@kudzu.us>,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: pci_pcie_cap invalid on AER/EEH enabled PPC?
Date: Wed, 06 Jul 2011 12:47:27 +1000 [thread overview]
Message-ID: <1309920447.14501.288.camel@pasglop> (raw)
In-Reply-To: <4E13A8F0.80700@linux.vnet.ibm.com>
On Tue, 2011-07-05 at 17:14 -0700, Richard A Lary wrote:
> I applied the debug patches mentioned above along with the lpfc patch
> http://marc.info/?l=linux-scsi&m=130919648513685&w=2
> to linux 3.0-rc6 kernel.
>
> The debug patches show that pci_dev members "is_pcie, pci_cap and pcie_type" are
> now all being set to correct values now that 'of_create_pci_dev()' calls
> 'set_pcie_port_type()'. I was not able to determine when this patch went in.
git is good for that :-)
bb209c8287d2d55ec4a67e3933346e0a3ee0da76:
Author: Benjamin Herrenschmidt <benh@kernel.crashing.org> 2010-01-27 04:10:03
Committer: Benjamin Herrenschmidt <benh@kernel.crashing.org> 2010-01-29 16:51:10
Parent: 4406c56d0a4da7a37b9180abeaece6cd00bcc874 (Merge branch 'linux-next' of git://git.kernel.org/pub/scm/linux/kernel/git/jbarnes/pci-2.6)
Child: 26b4a0ca46985ae9586c194f7859f3838b1230f8 (powerpc/pci: Add missing hookup to pci_slot)
Branches: many (38)
Follows: v2.6.33-rc5
Precedes: v2.6.33-rc7
powerpc/pci: Add calls to set_pcie_port_type() and set_pcie_hotplug_bridge()
We are missing these when building the pci_dev from scratch off
the Open Firmware device-tree
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Acked-by: Jesse Barnes <jbarnes@virtuousgeek.org>
We should probably backport it to .32-stable. Any volunteer ?
You might also want to consider for backport:
26b4a0ca46985ae9586c194f7859f3838b1230f8 and
94afc008e1e6fbadfac0b75fcf193b6d7074b2f1
> My tests show that lpfc driver now recovers from injected PCIe bus errors
> using test the 'if (pci_is_pcie(pdev))' for PCIe adapter type.
>
> I did not apply the test patch which changed the location of
> set_pcie_port_type(dev) in of_create_pci_dev(). I can apply and test
> this change if you think it is necessary?
No I think we call it in the right place, which mirrors
pci_setup_device(), that is before the early quirk.
> Based upon these results, I will ACK the change to the lpfc driver for
> "[PATCH 03/19] lpfc: remove unnecessary read of PCI_CAP_ID_EXP".
> I suspect that other drivers which are modified to use 'if (pci_is_pcie(pdev))'
> will work on Power PC as well, but I did not test any drivers other than lpfc.
Cheers,
Ben.
next prev parent reply other threads:[~2011-07-06 2:47 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-01 15:24 pci_pcie_cap invalid on AER/EEH enabled PPC? Jon Mason
2011-07-01 18:30 ` Richard A Lary
2011-07-01 19:02 ` Jon Mason
2011-07-01 20:00 ` Richard A Lary
2011-07-05 15:41 ` Richard A Lary
2011-07-05 16:18 ` Jon Mason
2011-07-05 17:22 ` Richard A Lary
2011-07-05 20:34 ` Richard A Lary
2011-07-06 0:14 ` Richard A Lary
2011-07-06 2:47 ` Benjamin Herrenschmidt [this message]
2011-07-06 2:42 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1309920447.14501.288.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=anton@au1.ibm.com \
--cc=davem@davemloft.net \
--cc=james.smart@emulex.com \
--cc=jdmason@kudzu.us \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rlary@linux.vnet.ibm.com \
--cc=rlary@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).