From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <a.p.zijlstra@chello.nl>
Received: from merlin.infradead.org (merlin.infradead.org
	[IPv6:2001:4978:20e::2])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(Client did not present a certificate)
	by ozlabs.org (Postfix) with ESMTPS id 63547B6F62
	for <linuxppc-dev@lists.ozlabs.org>;
	Fri, 15 Jul 2011 18:21:18 +1000 (EST)
Subject: Re: [PATCH 0/1] Fixup write permission of TLB on powerpc e500 core
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Shan Hai <haishan.bai@gmail.com>
In-Reply-To: <1310717238-13857-1-git-send-email-haishan.bai@gmail.com>
References: <1310717238-13857-1-git-send-email-haishan.bai@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Date: Fri, 15 Jul 2011 10:20:56 +0200
Message-ID: <1310718056.2586.275.camel@twins>
Mime-Version: 1.0
Cc: tony.luck@intel.com, linux-kernel@vger.kernel.org, cmetcalf@tilera.com,
	dhowells@redhat.com, paulus@samba.org, tglx@linutronix.de,
	walken@google.com, linuxppc-dev@lists.ozlabs.org, akpm@linux-foundation.org
List-Id: Linux on PowerPC Developers Mail List <linuxppc-dev.lists.ozlabs.org>
List-Unsubscribe: <https://lists.ozlabs.org/options/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=unsubscribe>
List-Archive: <http://lists.ozlabs.org/pipermail/linuxppc-dev>
List-Post: <mailto:linuxppc-dev@lists.ozlabs.org>
List-Help: <mailto:linuxppc-dev-request@lists.ozlabs.org?subject=help>
List-Subscribe: <https://lists.ozlabs.org/listinfo/linuxppc-dev>,
	<mailto:linuxppc-dev-request@lists.ozlabs.org?subject=subscribe>

On Fri, 2011-07-15 at 16:07 +0800, Shan Hai wrote:
>=20
> The following test case could reveal a bug in the futex_lock_pi()
>=20
> BUG: On FUTEX_LOCK_PI, there is a infinite loop in the futex_lock_pi()=
=20
>         on Powerpc e500 core.
> Cause: The linux kernel on the e500 core has no write permission on
>         the COW page, refer the head comment of the following test code.
> =20
> ftrace on test case:
> [000]   353.990181: futex_lock_pi_atomic <-futex_lock_pi
> [000]   353.990185: cmpxchg_futex_value_locked <-futex_lock_pi_atomic
> [snip]
> [000]   353.990191: do_page_fault <-handle_page_fault
> [000]   353.990192: bad_page_fault <-handle_page_fault
> [000]   353.990193: search_exception_tables <-bad_page_fault
> [snip]
> [000]   353.990199: get_user_pages <-fault_in_user_writeable
> [snip]
> [000]   353.990208: mark_page_accessed <-follow_page
> [000]   353.990222: futex_lock_pi_atomic <-futex_lock_pi
> [snip]
> [000]   353.990230: cmpxchg_futex_value_locked <-futex_lock_pi_atomic
> [ a loop occures here ]
>=20


But but but but, that get_user_pages(.write=3D1, .force=3D0) should result
in a COW break, getting our own writable page.

What is this e500 thing smoking that this doesn't work?