* [PATCH] powerpc/kvm: fix build errors with older toolchains
@ 2011-08-03 18:55 Nishanth Aravamudan
2011-08-10 14:58 ` Alexander Graf
0 siblings, 1 reply; 4+ messages in thread
From: Nishanth Aravamudan @ 2011-08-03 18:55 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: kvm, Marcelo Tosatti, Alexander Graf, kvm-ppc, linux-kernel,
Paul Mackerras, Avi Kivity, linuxppc-dev
On a box with gcc 4.3.2, I see errors like:
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x
arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
---
arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
index 6dd3358..de29501 100644
--- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
+++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
@@ -1251,7 +1251,7 @@ BEGIN_FTR_SECTION
reg = 0
.rept 32
li r6,reg*16+VCPU_VSRS
- stxvd2x reg,r6,r3
+ STXVD2X(reg,r6,r3)
reg = reg + 1
.endr
FTR_SECTION_ELSE
@@ -1313,7 +1313,7 @@ BEGIN_FTR_SECTION
reg = 0
.rept 32
li r7,reg*16+VCPU_VSRS
- lxvd2x reg,r7,r4
+ LXVD2X(reg,r7,r4)
reg = reg + 1
.endr
FTR_SECTION_ELSE
--
1.7.4.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/kvm: fix build errors with older toolchains
2011-08-03 18:55 [PATCH] powerpc/kvm: fix build errors with older toolchains Nishanth Aravamudan
@ 2011-08-10 14:58 ` Alexander Graf
2011-08-10 18:56 ` Benjamin Herrenschmidt
0 siblings, 1 reply; 4+ messages in thread
From: Alexander Graf @ 2011-08-10 14:58 UTC (permalink / raw)
To: Nishanth Aravamudan
Cc: kvm, Marcelo Tosatti, linux-kernel, kvm-ppc, Paul Mackerras,
Avi Kivity, linuxppc-dev
On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote:
> On a box with gcc 4.3.2, I see errors like:
>
> arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x
> arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x
Paul, mind to ack?
Alex
> Signed-off-by: Nishanth Aravamudan<nacc@us.ibm.com>
> ---
> arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> index 6dd3358..de29501 100644
> --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> @@ -1251,7 +1251,7 @@ BEGIN_FTR_SECTION
> reg = 0
> .rept 32
> li r6,reg*16+VCPU_VSRS
> - stxvd2x reg,r6,r3
> + STXVD2X(reg,r6,r3)
> reg = reg + 1
> .endr
> FTR_SECTION_ELSE
> @@ -1313,7 +1313,7 @@ BEGIN_FTR_SECTION
> reg = 0
> .rept 32
> li r7,reg*16+VCPU_VSRS
> - lxvd2x reg,r7,r4
> + LXVD2X(reg,r7,r4)
> reg = reg + 1
> .endr
> FTR_SECTION_ELSE
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/kvm: fix build errors with older toolchains
2011-08-10 14:58 ` Alexander Graf
@ 2011-08-10 18:56 ` Benjamin Herrenschmidt
2011-08-10 21:46 ` Alexander Graf
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Herrenschmidt @ 2011-08-10 18:56 UTC (permalink / raw)
To: Alexander Graf
Cc: kvm, Marcelo Tosatti, linux-kernel, kvm-ppc, Paul Mackerras,
Avi Kivity, Nishanth Aravamudan, linuxppc-dev
On Wed, 2011-08-10 at 16:58 +0200, Alexander Graf wrote:
> On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote:
> > On a box with gcc 4.3.2, I see errors like:
> >
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized opcode: stxvd2x
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized opcode: lxvd2x
>
> Paul, mind to ack?
I merged it already :-) It was trivial & annoying enough.
Cheers,
Ben.
>
> Alex
>
> > Signed-off-by: Nishanth Aravamudan<nacc@us.ibm.com>
> > ---
> > arch/powerpc/kvm/book3s_hv_rmhandlers.S | 4 ++--
> > 1 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/powerpc/kvm/book3s_hv_rmhandlers.S b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > index 6dd3358..de29501 100644
> > --- a/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > +++ b/arch/powerpc/kvm/book3s_hv_rmhandlers.S
> > @@ -1251,7 +1251,7 @@ BEGIN_FTR_SECTION
> > reg = 0
> > .rept 32
> > li r6,reg*16+VCPU_VSRS
> > - stxvd2x reg,r6,r3
> > + STXVD2X(reg,r6,r3)
> > reg = reg + 1
> > .endr
> > FTR_SECTION_ELSE
> > @@ -1313,7 +1313,7 @@ BEGIN_FTR_SECTION
> > reg = 0
> > .rept 32
> > li r7,reg*16+VCPU_VSRS
> > - lxvd2x reg,r7,r4
> > + LXVD2X(reg,r7,r4)
> > reg = reg + 1
> > .endr
> > FTR_SECTION_ELSE
>
> --
> To unsubscribe from this list: send the line "unsubscribe kvm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] powerpc/kvm: fix build errors with older toolchains
2011-08-10 18:56 ` Benjamin Herrenschmidt
@ 2011-08-10 21:46 ` Alexander Graf
0 siblings, 0 replies; 4+ messages in thread
From: Alexander Graf @ 2011-08-10 21:46 UTC (permalink / raw)
To: Benjamin Herrenschmidt
Cc: kvm, Marcelo Tosatti, linux-kernel, kvm-ppc, Paul Mackerras,
Avi Kivity, Nishanth Aravamudan, linuxppc-dev
On 10.08.2011, at 20:56, Benjamin Herrenschmidt wrote:
> On Wed, 2011-08-10 at 16:58 +0200, Alexander Graf wrote:
>> On 08/03/2011 08:55 PM, Nishanth Aravamudan wrote:
>>> On a box with gcc 4.3.2, I see errors like:
>>>=20
>>> arch/powerpc/kvm/book3s_hv_rmhandlers.S:1254: Error: Unrecognized =
opcode: stxvd2x
>>> arch/powerpc/kvm/book3s_hv_rmhandlers.S:1316: Error: Unrecognized =
opcode: lxvd2x
>>=20
>> Paul, mind to ack?
>=20
> I merged it already :-) It was trivial & annoying enough.
Alright then, I won't touch it :)
Alex
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-08-10 21:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-08-03 18:55 [PATCH] powerpc/kvm: fix build errors with older toolchains Nishanth Aravamudan
2011-08-10 14:58 ` Alexander Graf
2011-08-10 18:56 ` Benjamin Herrenschmidt
2011-08-10 21:46 ` Alexander Graf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).