From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Suzuki Poulose <suzuki@in.ibm.com>
Cc: mikey@neuling.org, "Ravi K. Nittala" <ravi.nittala@in.ibm.com>,
sbest@us.ibm.com, antonb@au1.ibm.com, subrata.modak@in.ibm.com,
ranittal@linux.vnet.ibm.com, linuxppc-dev@lists.ozlabs.org,
divya.vikas@in.ibm.com
Subject: Re: [PATCH] PSeries: Cancel RTAS event scan before firmware flash
Date: Tue, 30 Aug 2011 16:21:41 +1000 [thread overview]
Message-ID: <1314685301.2488.84.camel@pasglop> (raw)
In-Reply-To: <1314685198.2488.83.camel@pasglop>
On Tue, 2011-08-30 at 16:19 +1000, Benjamin Herrenschmidt wrote:
> On Tue, 2011-08-30 at 11:47 +0530, Suzuki Poulose wrote:
> > >
> >
> > The flash operation is performed in the reboot path at the very end.
> > So, even if we restart the event scan, the thread may not be able to
> > process
> > the events. Hence we thought we would leave it stopped.
> >
> > Again, we do not have much expertise in deciding which is the best
> > thing to do.
> > We could resume the event scan, if you think that is needed.
> >
> > Thanks for the review.
>
> No that's ok, I'll merge the patch as-is then.
Actually, please dbl check you get the dependencies right. The event
scan stuff is only compiled if CONFIG_PPC_RTAS_DAEMON is set, but the
rtas flash code depends on a different config option that can be set
independently.
So at the very least you need an ifdef to guard the cross-call
Cheers,
Ben.
next prev parent reply other threads:[~2011-08-30 6:22 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-27 12:09 [PATCH] PSeries: Cancel RTAS event scan before firmware flash Ravi K. Nittala
2011-08-08 6:46 ` Suzuki Poulose
2011-08-30 6:03 ` Benjamin Herrenschmidt
2011-08-30 6:17 ` Suzuki Poulose
2011-08-30 6:19 ` Benjamin Herrenschmidt
2011-08-30 6:21 ` Benjamin Herrenschmidt [this message]
2011-08-30 6:57 ` Suzuki Poulose
-- strict thread matches above, loose matches on Subject: below --
2011-09-21 10:29 Ravi K Nittala
2011-09-23 0:38 ` Benjamin Herrenschmidt
2011-10-04 7:49 Ravi K Nittala
2011-10-04 7:54 ` Subrata Modak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1314685301.2488.84.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=antonb@au1.ibm.com \
--cc=divya.vikas@in.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mikey@neuling.org \
--cc=ranittal@linux.vnet.ibm.com \
--cc=ravi.nittala@in.ibm.com \
--cc=sbest@us.ibm.com \
--cc=subrata.modak@in.ibm.com \
--cc=suzuki@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).