* [PATCH] powerpc/ps3: Fix lv1_gpu_attribute hcall
@ 2011-10-12 18:42 Geoff Levand
2011-10-13 5:58 ` Takashi Iwai
0 siblings, 1 reply; 2+ messages in thread
From: Geoff Levand @ 2011-10-12 18:42 UTC (permalink / raw)
To: Benjamin Herrenschmidt; +Cc: Takashi Iwai, linuxppc-dev, cbe-oss-dev
The lv1_gpu_attribute hcall takes three, not five input
arguments. Adjust the lv1 hcall table and all calls.
Signed-off-by: Geoff Levand <geoff@infradead.org>
CC: Takashi Iwai <tiwai@suse.de>
---
arch/powerpc/include/asm/lv1call.h | 2 +-
sound/ppc/snd_ps3.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
--- a/arch/powerpc/include/asm/lv1call.h
+++ b/arch/powerpc/include/asm/lv1call.h
@@ -315,7 +315,7 @@ LV1_CALL(gpu_context_free,
LV1_CALL(gpu_context_iomap, 5, 0, 221 )
LV1_CALL(gpu_context_attribute, 6, 0, 225 )
LV1_CALL(gpu_context_intr, 1, 1, 227 )
-LV1_CALL(gpu_attribute, 5, 0, 228 )
+LV1_CALL(gpu_attribute, 3, 0, 228 )
LV1_CALL(get_rtc, 0, 2, 232 )
LV1_CALL(set_ppe_periodic_tracer_frequency, 1, 0, 240 )
LV1_CALL(start_ppe_periodic_tracer, 5, 0, 241 )
--- a/sound/ppc/snd_ps3.c
+++ b/sound/ppc/snd_ps3.c
@@ -875,7 +875,7 @@ static void __devinit snd_ps3_audio_set_
(0x0fUL << 12) |
(PS3_AUDIO_IOID);
- ret = lv1_gpu_attribute(0x100, 0x007, val, 0, 0);
+ ret = lv1_gpu_attribute(0x100, 0x007, val);
if (ret)
pr_info("%s: gpu_attribute failed %d\n", __func__,
ret);
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] powerpc/ps3: Fix lv1_gpu_attribute hcall
2011-10-12 18:42 [PATCH] powerpc/ps3: Fix lv1_gpu_attribute hcall Geoff Levand
@ 2011-10-13 5:58 ` Takashi Iwai
0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2011-10-13 5:58 UTC (permalink / raw)
To: Geoff Levand; +Cc: cbe-oss-dev, linuxppc-dev
At Wed, 12 Oct 2011 11:42:13 -0700,
Geoff Levand wrote:
>
> The lv1_gpu_attribute hcall takes three, not five input
> arguments. Adjust the lv1 hcall table and all calls.
>
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> CC: Takashi Iwai <tiwai@suse.de>
Acked-by: Takashi Iwai <tiwai@suse.de>
> ---
> arch/powerpc/include/asm/lv1call.h | 2 +-
> sound/ppc/snd_ps3.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> --- a/arch/powerpc/include/asm/lv1call.h
> +++ b/arch/powerpc/include/asm/lv1call.h
> @@ -315,7 +315,7 @@ LV1_CALL(gpu_context_free,
> LV1_CALL(gpu_context_iomap, 5, 0, 221 )
> LV1_CALL(gpu_context_attribute, 6, 0, 225 )
> LV1_CALL(gpu_context_intr, 1, 1, 227 )
> -LV1_CALL(gpu_attribute, 5, 0, 228 )
> +LV1_CALL(gpu_attribute, 3, 0, 228 )
> LV1_CALL(get_rtc, 0, 2, 232 )
> LV1_CALL(set_ppe_periodic_tracer_frequency, 1, 0, 240 )
> LV1_CALL(start_ppe_periodic_tracer, 5, 0, 241 )
> --- a/sound/ppc/snd_ps3.c
> +++ b/sound/ppc/snd_ps3.c
> @@ -875,7 +875,7 @@ static void __devinit snd_ps3_audio_set_
> (0x0fUL << 12) |
> (PS3_AUDIO_IOID);
>
> - ret = lv1_gpu_attribute(0x100, 0x007, val, 0, 0);
> + ret = lv1_gpu_attribute(0x100, 0x007, val);
> if (ret)
> pr_info("%s: gpu_attribute failed %d\n", __func__,
> ret);
>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-10-13 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-12 18:42 [PATCH] powerpc/ps3: Fix lv1_gpu_attribute hcall Geoff Levand
2011-10-13 5:58 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).