From: Kumar Gala <galak@kernel.crashing.org>
To: hjk@hansjkoch.de
Cc: Greg KH <greg@kroah.com>,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org
Subject: [RFC][PATCH 1/2] uio: allow drivers to override the pgprot for mmap
Date: Fri, 28 Oct 2011 10:50:29 -0500 [thread overview]
Message-ID: <1319817030-23992-1-git-send-email-galak@kernel.crashing.org> (raw)
For some devices, the default behavior of pgprot_noncached() is not
appropriate for all of its mappable regions. This provides a means for
the kernel side of the UIO driver to override the flags without having
to implement its own full mmap callback.
Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
Signed-off-by: Geoff Thorpe <geoff@geoffthorpe.net>
---
drivers/uio/uio.c | 6 +++++-
include/linux/uio_driver.h | 3 +++
2 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/drivers/uio/uio.c b/drivers/uio/uio.c
index dc27d89..0aebe27 100644
--- a/drivers/uio/uio.c
+++ b/drivers/uio/uio.c
@@ -655,7 +655,11 @@ static int uio_mmap_physical(struct vm_area_struct *vma)
vma->vm_flags |= VM_IO | VM_RESERVED;
- vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
+ if (idev->info->set_pgprot)
+ vma->vm_page_prot = idev->info->set_pgprot(idev->info, mi,
+ vma->vm_page_prot);
+ else
+ vma->vm_page_prot = pgprot_noncached(vma->vm_page_prot);
return remap_pfn_range(vma,
vma->vm_start,
diff --git a/include/linux/uio_driver.h b/include/linux/uio_driver.h
index fd99ff9..edfe7c8 100644
--- a/include/linux/uio_driver.h
+++ b/include/linux/uio_driver.h
@@ -80,6 +80,7 @@ struct uio_device;
* @open: open operation for this uio device
* @release: release operation for this uio device
* @irqcontrol: disable/enable irqs when 0/1 is written to /dev/uioX
+ * @set_pgprot: allow driver to override default(noncached) pgprot
*/
struct uio_info {
struct uio_device *uio_dev;
@@ -95,6 +96,8 @@ struct uio_info {
int (*open)(struct uio_info *info, struct inode *inode);
int (*release)(struct uio_info *info, struct inode *inode);
int (*irqcontrol)(struct uio_info *info, s32 irq_on);
+ pgprot_t (*set_pgprot)(struct uio_info *uio, unsigned int mem_idx,
+ pgprot_t prot);
};
extern int __must_check
--
1.7.3.4
next reply other threads:[~2011-10-28 15:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-28 15:50 Kumar Gala [this message]
2011-10-28 15:50 ` [RFC][PATCH 2/2] Example to show use of uio pgprot Kumar Gala
2011-10-28 16:37 ` Greg KH
2011-10-28 17:52 ` Kumar Gala
2011-10-28 21:40 ` Hans J. Koch
2011-10-28 21:48 ` [RFC][PATCH 1/2] uio: allow drivers to override the pgprot for mmap Hans J. Koch
2011-10-29 6:38 ` Greg KH
2011-10-31 13:44 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1319817030-23992-1-git-send-email-galak@kernel.crashing.org \
--to=galak@kernel.crashing.org \
--cc=greg@kroah.com \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).