* [PATCH v2] USB: fsl_udc_core: use usb_endpoint_xfer_isoc to judge ISO XFER
@ 2011-11-22 1:55 Peter Chen
2011-11-22 1:57 ` Michal Nazarewicz
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Peter Chen @ 2011-11-22 1:55 UTC (permalink / raw)
To: leoli, balbi, mina86; +Cc: gregkh, linuxppc-dev, linux-usb, hzpeterchen, stable
Some ISO gadgets, like audio, has SYNC attribute as well as
USB_ENDPOINT_XFER_ISOC for their bmAttributes at ISO endpoint
descriptor. So, it needs to use usb_endpoint_xfer_isoc to judge
ISO XFER.
Signed-off-by: Peter Chen <peter.chen@freescale.com>
---
drivers/usb/gadget/fsl_udc_core.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/fsl_udc_core.c b/drivers/usb/gadget/fsl_udc_core.c
index d786ba3..91df255 100644
--- a/drivers/usb/gadget/fsl_udc_core.c
+++ b/drivers/usb/gadget/fsl_udc_core.c
@@ -877,7 +877,7 @@ fsl_ep_queue(struct usb_ep *_ep, struct usb_request *_req, gfp_t gfp_flags)
VDBG("%s, bad ep", __func__);
return -EINVAL;
}
- if (ep->desc->bmAttributes == USB_ENDPOINT_XFER_ISOC) {
+ if (usb_endpoint_xfer_isoc(ep->desc)) {
if (req->req.length > ep->ep.maxpacket)
return -EMSGSIZE;
}
@@ -1032,7 +1032,7 @@ static int fsl_ep_set_halt(struct usb_ep *_ep, int value)
goto out;
}
- if (ep->desc->bmAttributes == USB_ENDPOINT_XFER_ISOC) {
+ if (usb_endpoint_xfer_isoc(ep->desc)) {
status = -EOPNOTSUPP;
goto out;
}
--
1.6.3.3
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH v2] USB: fsl_udc_core: use usb_endpoint_xfer_isoc to judge ISO XFER
2011-11-22 1:55 [PATCH v2] USB: fsl_udc_core: use usb_endpoint_xfer_isoc to judge ISO XFER Peter Chen
@ 2011-11-22 1:57 ` Michal Nazarewicz
2011-11-22 3:11 ` Li Yang-R58472
2011-11-24 9:47 ` Felipe Balbi
2 siblings, 0 replies; 4+ messages in thread
From: Michal Nazarewicz @ 2011-11-22 1:57 UTC (permalink / raw)
To: leoli, balbi, Peter Chen
Cc: gregkh, linuxppc-dev, linux-usb, hzpeterchen, stable
On Tue, 22 Nov 2011 02:55:45 +0100, Peter Chen <peter.chen@freescale.com=
> wrote:
> Some ISO gadgets, like audio, has SYNC attribute as well as
> USB_ENDPOINT_XFER_ISOC for their bmAttributes at ISO endpoint
> descriptor. So, it needs to use usb_endpoint_xfer_isoc to judge
> ISO XFER.
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
Acked-by: Michal Nazarewicz <mina86@mina86.com>
> @@ -877,7 +877,7 @@ fsl_ep_queue(struct usb_ep *_ep, struct usb_reques=
t *_req, gfp_t gfp_flags)
> VDBG("%s, bad ep", __func__);
> return -EINVAL;
> }
> - if (ep->desc->bmAttributes =3D=3D USB_ENDPOINT_XFER_ISOC) {
> + if (usb_endpoint_xfer_isoc(ep->desc)) {
> if (req->req.length > ep->ep.maxpacket)
> return -EMSGSIZE;
> }
> @@ -1032,7 +1032,7 @@ static int fsl_ep_set_halt(struct usb_ep *_ep, i=
nt value)
> goto out;
> }
>- if (ep->desc->bmAttributes =3D=3D USB_ENDPOINT_XFER_ISOC) {
> + if (usb_endpoint_xfer_isoc(ep->desc)) {
> status =3D -EOPNOTSUPP;
> goto out;
> }
-- =
Best regards, _ _
.o. | Liege of Serenely Enlightened Majesty of o' \,=3D./ `o
..o | Computer Science, Micha=C5=82 =E2=80=9Cmina86=E2=80=9D Nazarewicz=
(o o)
ooo +----<email/xmpp: mpn@google.com>--------------ooO--(_)--Ooo--
^ permalink raw reply [flat|nested] 4+ messages in thread* RE: [PATCH v2] USB: fsl_udc_core: use usb_endpoint_xfer_isoc to judge ISO XFER
2011-11-22 1:55 [PATCH v2] USB: fsl_udc_core: use usb_endpoint_xfer_isoc to judge ISO XFER Peter Chen
2011-11-22 1:57 ` Michal Nazarewicz
@ 2011-11-22 3:11 ` Li Yang-R58472
2011-11-24 9:47 ` Felipe Balbi
2 siblings, 0 replies; 4+ messages in thread
From: Li Yang-R58472 @ 2011-11-22 3:11 UTC (permalink / raw)
To: Chen Peter-B29397, balbi@ti.com, mina86@mina86.com
Cc: gregkh@suse.de, linuxppc-dev@lists.ozlabs.org,
linux-usb@vger.kernel.org, hzpeterchen@gmail.com,
stable@kernel.org
PiBTdWJqZWN0OiBbUEFUQ0ggdjJdIFVTQjogZnNsX3VkY19jb3JlOiB1c2UgdXNiX2VuZHBvaW50
X3hmZXJfaXNvYyB0byBqdWRnZSBJU08NCj4gWEZFUg0KPiANCj4gU29tZSBJU08gZ2FkZ2V0cywg
bGlrZSBhdWRpbywgaGFzIFNZTkMgYXR0cmlidXRlIGFzIHdlbGwgYXMNCj4gVVNCX0VORFBPSU5U
X1hGRVJfSVNPQyBmb3IgdGhlaXIgYm1BdHRyaWJ1dGVzIGF0IElTTyBlbmRwb2ludCBkZXNjcmlw
dG9yLiBTbywgaXQNCj4gbmVlZHMgdG8gdXNlIHVzYl9lbmRwb2ludF94ZmVyX2lzb2MgdG8ganVk
Z2UgSVNPIFhGRVIuDQo+IA0KPiBTaWduZWQtb2ZmLWJ5OiBQZXRlciBDaGVuIDxwZXRlci5jaGVu
QGZyZWVzY2FsZS5jb20+DQoNCkFja2VkLWJ5OiBMaSBZYW5nIDxsZW9saUBmcmVlc2NhbGUuY29t
Pg0KDQotIExlbw0K
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] USB: fsl_udc_core: use usb_endpoint_xfer_isoc to judge ISO XFER
2011-11-22 1:55 [PATCH v2] USB: fsl_udc_core: use usb_endpoint_xfer_isoc to judge ISO XFER Peter Chen
2011-11-22 1:57 ` Michal Nazarewicz
2011-11-22 3:11 ` Li Yang-R58472
@ 2011-11-24 9:47 ` Felipe Balbi
2 siblings, 0 replies; 4+ messages in thread
From: Felipe Balbi @ 2011-11-24 9:47 UTC (permalink / raw)
To: Peter Chen
Cc: gregkh, linux-usb, mina86, balbi, linuxppc-dev, stable,
hzpeterchen
[-- Attachment #1: Type: text/plain, Size: 362 bytes --]
On Tue, Nov 22, 2011 at 09:55:45AM +0800, Peter Chen wrote:
> Some ISO gadgets, like audio, has SYNC attribute as well as
> USB_ENDPOINT_XFER_ISOC for their bmAttributes at ISO endpoint
> descriptor. So, it needs to use usb_endpoint_xfer_isoc to judge
> ISO XFER.
>
> Signed-off-by: Peter Chen <peter.chen@freescale.com>
applied, thanks
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-11-24 9:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-11-22 1:55 [PATCH v2] USB: fsl_udc_core: use usb_endpoint_xfer_isoc to judge ISO XFER Peter Chen
2011-11-22 1:57 ` Michal Nazarewicz
2011-11-22 3:11 ` Li Yang-R58472
2011-11-24 9:47 ` Felipe Balbi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).