From: <b29237@freescale.com>
To: <dan.j.williams@intel.com>, <leoli@freescale.com>,
<zw@zh-kernel.org>, <vinod.koul@intel.com>
Cc: Forrest Shi <b29237@freescale.com>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: [PATCH][RFC] fsldma: fix performance degradation by optimizing spinlock use.
Date: Tue, 22 Nov 2011 12:55:05 +0800 [thread overview]
Message-ID: <1321937705-19587-1-git-send-email-b29237@freescale.com> (raw)
From: Forrest Shi <b29237@freescale.com>
dma status check function fsl_tx_status is heavily called in
a tight loop and the desc lock in fsl_tx_status contended by
the dma status update function. this caused the dma performance
degrades much.
this patch releases the lock in the fsl_tx_status function.
I believe it has no neglect impact on the following call of
dma_async_is_complete(...).
we can see below three conditions will be identified as success
a) x < complete < use
b) x < complete+N < use+N
c) x < complete < use+N
here complete is the completed_cookie, use is the last_used
cookie, x is the querying cookie, N is MAX cookie
when chan->completed_cookie is being read, the last_used may
be incresed. Anyway it has no neglect impact on the dma status
decision.
Signed-off-by: Forrest Shi <xuelin.shi@freescale.com>
---
drivers/dma/fsldma.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
index 8a78154..1dca56f 100644
--- a/drivers/dma/fsldma.c
+++ b/drivers/dma/fsldma.c
@@ -986,15 +986,10 @@ static enum dma_status fsl_tx_status(struct dma_chan *dchan,
struct fsldma_chan *chan = to_fsl_chan(dchan);
dma_cookie_t last_complete;
dma_cookie_t last_used;
- unsigned long flags;
-
- spin_lock_irqsave(&chan->desc_lock, flags);
last_complete = chan->completed_cookie;
last_used = dchan->cookie;
- spin_unlock_irqrestore(&chan->desc_lock, flags);
-
dma_set_tx_state(txstate, last_complete, last_used, 0);
return dma_async_is_complete(cookie, last_complete, last_used);
}
--
1.7.0.4
next reply other threads:[~2011-11-22 6:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 4:55 b29237 [this message]
2011-11-22 18:59 ` [PATCH][RFC] fsldma: fix performance degradation by optimizing spinlock use Ira W. Snyder
2011-11-24 8:12 ` Shi Xuelin-B29237
2011-11-28 16:38 ` Ira W. Snyder
2011-11-29 3:19 ` Li Yang-R58472
2011-11-29 17:25 ` Ira W. Snyder
2011-11-30 0:08 ` Tabi Timur-B04825
2011-11-30 9:57 ` Shi Xuelin-B29237
2011-11-30 17:07 ` Ira W. Snyder
2011-12-02 3:47 ` Shi Xuelin-B29237
2011-12-02 17:13 ` Ira W. Snyder
2011-12-05 6:11 ` Shi Xuelin-B29237
2011-11-29 19:49 ` Scott Wood
2011-11-29 3:41 ` Shi Xuelin-B29237
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321937705-19587-1-git-send-email-b29237@freescale.com \
--to=b29237@freescale.com \
--cc=dan.j.williams@intel.com \
--cc=leoli@freescale.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=vinod.koul@intel.com \
--cc=zw@zh-kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).