From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: devicetree-discuss@lists.ozlabs.org,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Tanmay Inamdar <tinamdar@apm.com>,
Rob Herring <rob.herring@calxeda.com>
Subject: Please revert commit dc9372808412edbc653a675a526c2ee6c0c14a91
Date: Wed, 23 Nov 2011 09:11:50 +1100 [thread overview]
Message-ID: <1321999910.14573.11.camel@pasglop> (raw)
Hi Linus !
Please, revert commit dc9372808412edbc653a675a526c2ee6c0c14a91
"of/irq: of_irq_find_parent: check for parent equal to child"
This breaks some powerpc platforms at least. The practice of having a
node provide an explicit "interrupt-parent" property pointing to itself
is an old trick that we've used in the past to allow a device-node to
have interrupts routed to different controllers.
In that case, the node also contains an interrupt-map, so the node is
its own parent, the interrupt resolution hits the map, which then can
route each individual interrupt to a different parent.
Cheers,
Ben.
next reply other threads:[~2011-11-22 22:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-22 22:11 Benjamin Herrenschmidt [this message]
2011-11-22 22:43 ` Please revert commit dc9372808412edbc653a675a526c2ee6c0c14a91 Grant Likely
2011-11-22 23:36 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1321999910.14573.11.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=rob.herring@calxeda.com \
--cc=tinamdar@apm.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).