From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Message-ID: <1321999910.14573.11.camel@pasglop> Subject: Please revert commit dc9372808412edbc653a675a526c2ee6c0c14a91 From: Benjamin Herrenschmidt To: Linus Torvalds Date: Wed, 23 Nov 2011 09:11:50 +1100 Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Cc: devicetree-discuss@lists.ozlabs.org, linuxppc-dev , Tanmay Inamdar , Rob Herring List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Hi Linus ! Please, revert commit dc9372808412edbc653a675a526c2ee6c0c14a91 "of/irq: of_irq_find_parent: check for parent equal to child" This breaks some powerpc platforms at least. The practice of having a node provide an explicit "interrupt-parent" property pointing to itself is an old trick that we've used in the past to allow a device-node to have interrupts routed to different controllers. In that case, the node also contains an interrupt-map, so the node is its own parent, the interrupt resolution hits the map, which then can route each individual interrupt to a different parent. Cheers, Ben.