From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kyle Moffett <kyle@moffetthome.net>
Cc: linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: MPIC cleanup series
Date: Mon, 28 Nov 2011 10:51:24 +1100 [thread overview]
Message-ID: <1322437884.23348.30.camel@pasglop> (raw)
Hi Kyle !
I can't reply to the patches themselves easily unfortunately as I
accidentally deleted them from my mailer :-)
Overall I really look your series. It doesn't quite apply cleanly
anymore so I'll as you for a new shoot after you address the comments
below, at which point, if you're fast enough, I'll stick it in -next :-)
Just a couple of comments on some of the patches:
- 5/10: search for open-pic device-tree node if NULL
The idea is fine, however most callers ignore the device-type and only
compare on compatible, while you replace that with a match entry that
seems to require matching on both. This is likely to break stuff. The
"type" part of te march entry should be NULL I believe.
- 9/10: cache the node
of_node_get() is your friend.
- 10/10: Makes me a bit nervous. It 'looks' right but I wouldn't bet on
Apple device-trees being sane vs. chaining. I would like a test that
doesn't do the cascade if the mpic is a primary to at least limit the
risk of messup.
Cheers,
Ben.
next reply other threads:[~2011-11-27 23:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-27 23:51 Benjamin Herrenschmidt [this message]
2011-11-28 20:48 ` MPIC cleanup series Kyle Moffett
2011-11-28 20:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322437884.23348.30.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=kyle@moffetthome.net \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).