linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Geoff Levand <geoff@infradead.org>
To: "David S. Miller" <davem@davemloft.net>
Cc: cbe-oss-dev@lists.ozlabs.org, linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH 2/8] powerpc/ps3: Fix hcall lv1_net_stop_rx_dma
Date: Tue, 29 Nov 2011 17:50:10 -0800	[thread overview]
Message-ID: <1322617810.3037.304.camel@gum> (raw)
In-Reply-To: <a4ecc1a889c6773a8ef6fd52ba0f49a705cac6d3.1322615824.git.geoff@infradead.org>

Hi Dave, 

Unfortunately, your address got cut off for this patch.

I think Ben can merge this one through his powerpc tree since it is just
a trivial change to the ps3 gelic net driver.

Please consider.

-Geoff

On Wed, 2011-11-30 at 01:38 +0000, Geoff Levand wrote:
> The lv1_net_stop_tx_dma and net_stop_rx_dma hcalls take 2, not 3 input
> arguments.  Adjust the lv1 hcall table and all calls.
> 
> Signed-off-by: Geoff Levand <geoff@infradead.org>
> ---
>  arch/powerpc/include/asm/lv1call.h           |    4 ++--
>  drivers/net/ethernet/toshiba/ps3_gelic_net.c |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/powerpc/include/asm/lv1call.h b/arch/powerpc/include/asm/lv1call.h
> index f77c708..807d895 100644
> --- a/arch/powerpc/include/asm/lv1call.h
> +++ b/arch/powerpc/include/asm/lv1call.h
> @@ -294,9 +294,9 @@ LV1_CALL(unmap_device_dma_region,                       4, 0, 177 )
>  LV1_CALL(net_add_multicast_address,                     4, 0, 185 )
>  LV1_CALL(net_remove_multicast_address,                  4, 0, 186 )
>  LV1_CALL(net_start_tx_dma,                              4, 0, 187 )
> -LV1_CALL(net_stop_tx_dma,                               3, 0, 188 )
> +LV1_CALL(net_stop_tx_dma,                               2, 0, 188 )
>  LV1_CALL(net_start_rx_dma,                              4, 0, 189 )
> -LV1_CALL(net_stop_rx_dma,                               3, 0, 190 )
> +LV1_CALL(net_stop_rx_dma,                               2, 0, 190 )
>  LV1_CALL(net_set_interrupt_status_indicator,            4, 0, 191 )
>  LV1_CALL(net_set_interrupt_mask,                        4, 0, 193 )
>  LV1_CALL(net_control,                                   6, 2, 194 )
> diff --git a/drivers/net/ethernet/toshiba/ps3_gelic_net.c b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
> index 7bf1e20..5ee82a7 100644
> --- a/drivers/net/ethernet/toshiba/ps3_gelic_net.c
> +++ b/drivers/net/ethernet/toshiba/ps3_gelic_net.c
> @@ -640,7 +640,7 @@ static inline void gelic_card_disable_rxdmac(struct gelic_card *card)
>  	int status;
>  
>  	/* this hvc blocks until the DMA in progress really stopped */
> -	status = lv1_net_stop_rx_dma(bus_id(card), dev_id(card), 0);
> +	status = lv1_net_stop_rx_dma(bus_id(card), dev_id(card));
>  	if (status)
>  		dev_err(ctodev(card),
>  			"lv1_net_stop_rx_dma failed, %d\n", status);
> @@ -658,7 +658,7 @@ static inline void gelic_card_disable_txdmac(struct gelic_card *card)
>  	int status;
>  
>  	/* this hvc blocks until the DMA in progress really stopped */
> -	status = lv1_net_stop_tx_dma(bus_id(card), dev_id(card), 0);
> +	status = lv1_net_stop_tx_dma(bus_id(card), dev_id(card));
>  	if (status)
>  		dev_err(ctodev(card),
>  			"lv1_net_stop_tx_dma failed, status=%d\n", status);

  reply	other threads:[~2011-11-30  1:50 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-30  1:38 [GIT PULL] PS3 updates for powerpc next Geoff Levand
2011-11-30  1:38 ` [PATCH 1/8] powerpc/ps3: Interrupt code cleanup Geoff Levand
2011-11-30  1:38 ` [PATCH 2/8] powerpc/ps3: Fix hcall lv1_net_stop_rx_dma Geoff Levand
2011-11-30  1:50   ` Geoff Levand [this message]
2011-11-30  1:38 ` [PATCH 3/8] powerpc/ps3: Fix hcall lv1_get_virtual_address_space_id_of_ppe Geoff Levand
2011-11-30  1:38 ` [PATCH 6/8] powerpc/ps3: Fix pr_debug build warnings Geoff Levand
2011-11-30 20:57   ` Geert Uytterhoeven
2011-12-01 18:58     ` [PATCH 6/8 v2] powerpc/ps3: Fix PS3 repository " Geoff Levand
2011-11-30  1:38 ` [PATCH 4/8] powerpc/ps3: Fix hcall lv1_get_version_info Geoff Levand
2011-11-30  1:38 ` [PATCH 5/8] powerpc/ps3: Fix hcall lv1_read_repository_node Geoff Levand
2011-11-30  1:38 ` [PATCH 7/8] powerpc/ps3: Add __init to ps3_smp_probe Geoff Levand
2011-11-30  1:38 ` [PATCH 8/8] powerpc/ps3: Update ps3_defconfig Geoff Levand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1322617810.3037.304.camel@gum \
    --to=geoff@infradead.org \
    --cc=cbe-oss-dev@lists.ozlabs.org \
    --cc=davem@davemloft.net \
    --cc=linuxppc-dev@lists.ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).