From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Josh Boyer <jwboyer@gmail.com>
Cc: Christoph Egger <siccegge@cs.fau.de>,
LinuxPPC-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH 3/6] 44x: Removing dead CONFIG_PPC47x
Date: Thu, 01 Dec 2011 07:20:07 +1100 [thread overview]
Message-ID: <1322684407.29041.1.camel@pasglop> (raw)
In-Reply-To: <CA+5PVA637ckfo60Foc_G_yhuJg6=fbuyQcjFDwYV_XFLkd6whA@mail.gmail.com>
On Wed, 2011-11-30 at 06:43 -0500, Josh Boyer wrote:
>
> That doesn't look right. The code is there doing something, why is it
> just being removed? I would think the change would be to use
> CONFIG_PPC_47x?
>
> Or if the code there isn't needed any longer, the changelog should say
> why.
Ah right, I tripped on this one too when reviewing then figured it out
but I agree, the changelog should be clearer.
If you notice, the original ifdef was in a function that is only ever
used on 44x. There's a separate function that handles 47x. I suppose
this is a leftover of the initial port which somebody forgot to remove.
So the patch is fine, but yes, the changelog could be made clearer.
Cheers,
Ben.
next prev parent reply other threads:[~2011-11-30 20:20 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 5:23 Add support for the currituck 476 platform from IBM Tony Breeds
2011-11-30 5:23 ` [PATCH 1/6] 44x/pci: Continue pci setup even if there is no sdr-base in the device-tree Tony Breeds
2011-11-30 5:46 ` Benjamin Herrenschmidt
2011-12-01 1:11 ` Tony Breeds
2011-11-30 5:23 ` [PATCH 2/6] 44x/pci: Setup the dma_window properties for each pci_controller Tony Breeds
2011-11-30 5:23 ` [PATCH 3/6] 44x: Removing dead CONFIG_PPC47x Tony Breeds
2011-11-30 11:43 ` Josh Boyer
2011-11-30 20:20 ` Benjamin Herrenschmidt [this message]
2011-11-30 5:23 ` [PATCH 4/6] powerpc/boot: Add extended precision shifts to the boot wrapper Tony Breeds
2011-11-30 5:48 ` Benjamin Herrenschmidt
2011-11-30 11:45 ` Josh Boyer
2011-11-30 20:21 ` Benjamin Herrenschmidt
2011-11-30 20:28 ` Scott Wood
2011-11-30 23:25 ` Tony Breeds
2011-11-30 5:23 ` [PATCH 5/6] powerpc/boot: Add mfdcrx Tony Breeds
2011-11-30 13:09 ` Segher Boessenkool
2011-11-30 18:10 ` David Laight
2011-12-01 22:55 ` Segher Boessenkool
2011-11-30 23:30 ` Tony Breeds
2011-11-30 23:35 ` Tony Breeds
2011-11-30 5:24 ` [PATCH 6/6] 44x/currituck: Add support for the new IBM currituck platform Tony Breeds
2011-11-30 6:20 ` Benjamin Herrenschmidt
2011-11-30 6:31 ` David Gibson
2011-12-01 4:05 ` Tony Breeds
2011-12-01 4:29 ` Tony Breeds
2011-11-30 13:23 ` Kumar Gala
2011-12-01 4:16 ` Tony Breeds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1322684407.29041.1.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jwboyer@gmail.com \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=siccegge@cs.fau.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).