From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Fix swiotlb ops for ppc64
Date: Thu, 08 Dec 2011 14:23:20 +1100 [thread overview]
Message-ID: <1323314600.12793.19.camel@pasglop> (raw)
In-Reply-To: <1323278391-21849-1-git-send-email-galak@kernel.crashing.org>
On Wed, 2011-12-07 at 11:19 -0600, Kumar Gala wrote:
> struct dma_map_ops swiotlb_dma_ops = {
> +#ifdef CONFIG_PPC64
> + .alloc_coherent = swiotlb_alloc_coherent,
> + .free_coherent = swiotlb_free_coherent,
> +#else
> .alloc_coherent = dma_direct_alloc_coherent,
> .free_coherent = dma_direct_free_coherent,
> +#endif
> .map_sg = swiotlb_map_sg_attrs,
> .unmap_sg = swiotlb_unmap_sg_attrs,
> .dma_supported = swiotlb_dma_supported,
Do we really need the ifdef ? What happens if we use
swiotlb_alloc_coherent() on ppc32 ? Won't it allocate lowmem, realize
that it doesn't need bouncing and be happy ?
Cheers,
Ben.
next prev parent reply other threads:[~2011-12-08 3:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-07 17:19 [PATCH] powerpc: Fix swiotlb ops for ppc64 Kumar Gala
2011-12-08 3:23 ` Benjamin Herrenschmidt [this message]
2011-12-08 5:46 ` Kumar Gala
2011-12-13 3:55 ` Becky Bruce
2011-12-13 4:27 ` Benjamin Herrenschmidt
2011-12-14 2:53 ` Becky Bruce
2011-12-14 3:00 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1323314600.12793.19.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).