From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: Gilad Ben-Yossef To: linux-kernel@vger.kernel.org Subject: [RFC PATCH 0/9] Remove useless on_each_cpu return value Date: Tue, 3 Jan 2012 16:19:04 +0200 Message-Id: <1325600353-10895-1-git-send-email-gilad@benyossef.com> Cc: linux-ia64@vger.kernel.org, David Airlie , Will Deacon , dri-devel@lists.freedesktop.org, Paul Mackerras , "H. Peter Anvin" , Russell King , x86@kernel.org, Ingo Molnar , Arnaldo Carvalho de Melo , Matt Turner , Fenghua Yu , Peter Zijlstra , devicetree-discuss@lists.ozlabs.org, Michal Nazarewicz , Gilad Ben-Yossef , Ivan Kokshaysky , Rob Herring , Thomas Gleixner , linux-arm-kernel@lists.infradead.org, Richard Henderson , Tony Luck , linux-alpha@vger.kernel.org, linuxppc-dev@lists.ozlabs.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , on_each_cpu() returns as its own return value the return value of smp_call_function(). smp_call_function() in turn returns a hard coded value of zero. Some callers to on_each_cpu() waste cycles and bloat code space by checking the return value to on_each_cpu(), probably for historical reasons. This patch set refactors callers to not test on_each_cpu() (fixed) return value and then refactors on_each_cpu to return void to avoid confusing future users. In other words, this patch aims to delete 18 source code lines while not changing any functionality :-) I tested as best as I could the x86 changes and compiled some of the others, but I don't have access to all the needed hardware for testing. Reviewers and testers welcome! CC: Michal Nazarewicz CC: David Airlie CC: dri-devel@lists.freedesktop.org CC: Benjamin Herrenschmidt CC: Paul Mackerras CC: Grant Likely CC: Rob Herring CC: linuxppc-dev@lists.ozlabs.org CC: devicetree-discuss@lists.ozlabs.org CC: Richard Henderson CC: Ivan Kokshaysky CC: Matt Turner CC: linux-alpha@vger.kernel.org CC: Thomas Gleixner CC: Ingo Molnar CC: "H. Peter Anvin" CC: x86@kernel.org CC: Tony Luck CC: Fenghua Yu CC: linux-ia64@vger.kernel.org CC: Will Deacon CC: Peter Zijlstra CC: Arnaldo Carvalho de Melo CC: Russell King CC: linux-arm-kernel@lists.infradead.org Gilad Ben-Yossef (9): arm: avoid using on_each_cpu hard coded ret value ia64: avoid using on_each_cpu hard coded ret value x86: avoid using on_each_cpu hard coded ret value alpha: avoid using on_each_cpu hard coded ret value ppc: avoid using on_each_cpu hard coded ret value agp: avoid using on_each_cpu hard coded ret value drm: avoid using on_each_cpu hard coded ret value smp: refactor on_each_cpu to void returning func x86: refactor wbinvd_on_all_cpus to void function arch/alpha/kernel/smp.c | 7 ++----- arch/arm/kernel/perf_event.c | 2 +- arch/ia64/kernel/perfmon.c | 12 ++---------- arch/powerpc/kernel/rtas.c | 3 +-- arch/x86/include/asm/smp.h | 5 ++--- arch/x86/lib/cache-smp.c | 4 ++-- drivers/char/agp/generic.c | 3 +-- drivers/gpu/drm/drm_cache.c | 3 +-- include/linux/smp.h | 7 +++---- kernel/smp.c | 6 ++---- 10 files changed, 17 insertions(+), 35 deletions(-)