From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linuxppc-dev@ozlabs.org, Shaohua Li <shaohua.li@intel.com>,
linux-pm@vger.kernel.org,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>
Subject: [PATCH] cpuidle: Default y for pseries
Date: Wed, 11 Jan 2012 12:05:35 +1100 [thread overview]
Message-ID: <1326243935.23910.85.camel@pasglop> (raw)
We just replaced the pseries platform idle loops with a cpuidle backend,
however that means that you won't get any power saving and won't return
any unused idle time to the hypervisor unless cpuidle is enabled.
Thus is should default to y when pseries is enabled. I prefer that to
a select so we can still make it modular if we want to.
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Linus, do you want to just pick that up or should I put it into powerpc.git
and ask you to pull ? I will have 2 or 3 other fixes there later today,
but I wanted to make sure you were ok with the approach with this
specific one.
diff --git a/drivers/cpuidle/Kconfig b/drivers/cpuidle/Kconfig
index 7dbc4a8..62ca70d 100644
--- a/drivers/cpuidle/Kconfig
+++ b/drivers/cpuidle/Kconfig
@@ -1,7 +1,8 @@
config CPU_IDLE
bool "CPU idle PM support"
- default ACPI
+ default y if ACPI
+ default y if PPC_PSERIES
help
CPU idle is a generic framework for supporting software-controlled
idle processor power management. It includes modular cross-platform
next reply other threads:[~2012-01-11 1:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-11 1:05 Benjamin Herrenschmidt [this message]
2012-01-11 6:08 ` [PATCH] cpuidle: Default y for pseries Linus Torvalds
2012-01-11 7:05 ` Benjamin Herrenschmidt
2012-01-11 22:37 ` Thadeu Lima de Souza Cascardo
2012-01-11 23:06 ` Benjamin Herrenschmidt
2012-01-12 13:05 ` Deepthi Dharwar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1326243935.23910.85.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-pm@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=shaohua.li@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).