[PATCH] powerpc/85xx: fix build failure from p1022 in SMP defconfig

[PATCH] powerpc/85xx: fix build failure from p1022 in SMP defconfig

[Paul Gortmaker]

Using the configs/mpc85xx_smp_defconfig shows this build error:

arch/powerpc/platforms/85xx/p1022_ds.c:341: error: 'udbg_progress' undeclared here (not in a function)

Adding in the obvious missing header <asm/udbg.h> fixes it.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>

diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c b/arch/powerpc/platforms/85xx/p1022_ds.c
index bb3d84f..aa4022e 100644
--- a/arch/powerpc/platforms/85xx/p1022_ds.c
+++ b/arch/powerpc/platforms/85xx/p1022_ds.c
@@ -26,6 +26,7 @@
 #include <sysdev/fsl_soc.h>
 #include <sysdev/fsl_pci.h>
 #include <asm/fsl_guts.h>
+#include <asm/udbg.h>
 #include "smp.h"
 
 #include "mpc85xx.h"
-- 
1.7.7.2

Re: [PATCH] powerpc/85xx: fix build failure from p1022 in SMP defconfig

[Paul Gortmaker]

On Sat, Jan 21, 2012 at 9:52 AM, Paul Gortmaker
<paul.gortmaker@windriver.com> wrote:
> Using the configs/mpc85xx_smp_defconfig shows this build error:
>
> arch/powerpc/platforms/85xx/p1022_ds.c:341: error: 'udbg_progress' undecl=
ared here (not in a function)
>
> Adding in the obvious missing header <asm/udbg.h> fixes it.

I just noticed this fix is a duplicate, it seems that it was already
queued back in Dec 11th last year:

http://patchwork.ozlabs.org/patch/130620/

...but for one reason or another didn't make it into 3.3-rc1.

P.

>
> Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
>
> diff --git a/arch/powerpc/platforms/85xx/p1022_ds.c b/arch/powerpc/platfo=
rms/85xx/p1022_ds.c
> index bb3d84f..aa4022e 100644
> --- a/arch/powerpc/platforms/85xx/p1022_ds.c
> +++ b/arch/powerpc/platforms/85xx/p1022_ds.c
> @@ -26,6 +26,7 @@
> =A0#include <sysdev/fsl_soc.h>
> =A0#include <sysdev/fsl_pci.h>
> =A0#include <asm/fsl_guts.h>
> +#include <asm/udbg.h>
> =A0#include "smp.h"
>
> =A0#include "mpc85xx.h"
> --
> 1.7.7.2
>
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@lists.ozlabs.org
> https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] powerpc/85xx: fix build failure from p1022 in SMP defconfig

[Kumar Gala]

On Jan 21, 2012, at 9:50 AM, Paul Gortmaker wrote:

> On Sat, Jan 21, 2012 at 9:52 AM, Paul Gortmaker
> <paul.gortmaker@windriver.com> wrote:
>> Using the configs/mpc85xx_smp_defconfig shows this build error:
>>=20
>> arch/powerpc/platforms/85xx/p1022_ds.c:341: error: 'udbg_progress' =
undeclared here (not in a function)
>>=20
>> Adding in the obvious missing header <asm/udbg.h> fixes it.
>=20
> I just noticed this fix is a duplicate, it seems that it was already
> queued back in Dec 11th last year:
>=20
> http://patchwork.ozlabs.org/patch/130620/
>=20
> ...but for one reason or another didn't make it into 3.3-rc1.
>=20
> P.

Ben just missed my pull request with it before 3.3-rc1.  Should get into =
rc2 or I'll have to get someone in ozlabs to beat ben for me ;)

- k=

Re: [PATCH] powerpc/85xx: fix build failure from p1022 in SMP defconfig

[Benjamin Herrenschmidt]

On Tue, 2012-01-24 at 16:55 -0600, Kumar Gala wrote:
> Ben just missed my pull request with it before 3.3-rc1.  Should get
> into rc2 or I'll have to get someone in ozlabs to beat ben for me ;)

Working on it :-)

Cheers,
Ben.