From: Artem Bityutskiy <dedekind1@gmail.com>
To: Prabhakar Kushwaha <prabhakar@freescale.com>
Cc: Scott Wood <scottwood@freescale.com>,
linux-mtd@lists.infradead.org, linuxppc-dev@lists.ozlabs.org,
Poonam Aggrwal <poonam.aggrwal@freescale.com>
Subject: Re: [PATCH] mtd/nand:Fix wrong usage of is_blank() in fsl_ifc_run_command
Date: Fri, 27 Jan 2012 15:15:33 +0200 [thread overview]
Message-ID: <1327670133.26648.40.camel@sauron.fi.intel.com> (raw)
In-Reply-To: <1326859991-7469-1-git-send-email-prabhakar@freescale.com>
[-- Attachment #1: Type: text/plain, Size: 816 bytes --]
On Wed, 2012-01-18 at 09:43 +0530, Prabhakar Kushwaha wrote:
> Freescale IFC NAND Machine calculates ECC on 512byte sector and same is used in
> fsl_ifc_run_command() during ECC status verification. Also this sector is passed
> to is_blank() for blank checking. It is wrong at first place because
> is_blank()'s implementation checks for Page size and OOB area size.
> is_blank() should be called per page for main and OOB area verification.
>
> Variables name are redefined to avoid confusion between buffer and ecc sector.
>
> Signed-off-by: Poonam Aggrwal <poonam.aggrwal@freescale.com>
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Signed-off-by: Prabhakar Kushwaha <prabhakar@freescale.com>
The driver is not in 3.3-rc1, so I skip this patch.
--
Best Regards,
Artem Bityutskiy
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2012-01-27 13:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-18 4:13 [PATCH] mtd/nand:Fix wrong usage of is_blank() in fsl_ifc_run_command Prabhakar Kushwaha
2012-01-20 20:20 ` Scott Wood
2012-01-27 13:15 ` Artem Bityutskiy [this message]
2012-01-27 14:20 ` Kushwaha Prabhakar-B32579
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1327670133.26648.40.camel@sauron.fi.intel.com \
--to=dedekind1@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=poonam.aggrwal@freescale.com \
--cc=prabhakar@freescale.com \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).